Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: ui/events/ozone/evdev/event_factory_evdev.h

Issue 863353003: [PATCH 6/11] ozone: evdev: Factor device I/O out of EventFactoryOzone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile with USE_EVDEV_GESTURES Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/ozone/BUILD.gn ('k') | ui/events/ozone/evdev/event_factory_evdev.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/ozone/evdev/event_factory_evdev.h
diff --git a/ui/events/ozone/evdev/event_factory_evdev.h b/ui/events/ozone/evdev/event_factory_evdev.h
index bd22d57636171770d59a71a071ae94aec9684c30..1d6c7bb36e94a616911585709f98ea9a2b34656e 100644
--- a/ui/events/ozone/evdev/event_factory_evdev.h
+++ b/ui/events/ozone/evdev/event_factory_evdev.h
@@ -5,9 +5,6 @@
#ifndef UI_EVENTS_OZONE_EVDEV_EVENT_FACTORY_EVDEV_H_
#define UI_EVENTS_OZONE_EVDEV_EVENT_FACTORY_EVDEV_H_
-#include <set>
-#include <vector>
-
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/files/file_path.h"
@@ -15,8 +12,6 @@
#include "base/task_runner.h"
#include "ui/events/ozone/device/device_event_observer.h"
#include "ui/events/ozone/evdev/device_event_dispatcher_evdev.h"
-#include "ui/events/ozone/evdev/event_converter_evdev.h"
-#include "ui/events/ozone/evdev/event_device_info.h"
#include "ui/events/ozone/evdev/event_modifiers_evdev.h"
#include "ui/events/ozone/evdev/events_ozone_evdev_export.h"
#include "ui/events/ozone/evdev/input_controller_evdev.h"
@@ -34,6 +29,7 @@ namespace ui {
class CursorDelegateEvdev;
class DeviceManager;
+class InputDeviceFactoryEvdev;
class SystemInputInjector;
enum class DomCode;
@@ -41,10 +37,6 @@ enum class DomCode;
#error Missing dependency on ui/events/ozone:events_ozone_evdev
#endif
-#if defined(USE_EVDEV_GESTURES)
-class GesturePropertyProvider;
-#endif
-
// Ozone events implementation for the Linux input subsystem ("evdev").
class EVENTS_OZONE_EVDEV_EXPORT EventFactoryEvdev
: public DeviceEventObserver,
@@ -59,27 +51,9 @@ class EVENTS_OZONE_EVDEV_EXPORT EventFactoryEvdev
// Initialize. Must be called with a valid message loop.
void Init();
- // Get a list of device ids that matches a device type. Return true if the
- // list is not empty. |device_ids| can be NULL.
- bool GetDeviceIdsByType(const EventDeviceType type,
- std::vector<int>* device_ids);
-
void WarpCursorTo(gfx::AcceleratedWidget widget,
const gfx::PointF& location);
- // Disables the internal touchpad.
- void DisableInternalTouchpad();
-
- // Enables the internal touchpad.
- void EnableInternalTouchpad();
-
- // Disables all keys on the internal keyboard except |excepted_keys|.
- void DisableInternalKeyboardExceptKeys(
- scoped_ptr<std::set<DomCode>> excepted_keys);
-
- // Enables all keys on the internal keyboard.
- void EnableInternalKeyboard();
-
scoped_ptr<SystemInputInjector> CreateSystemInputInjector();
InputController* input_controller() { return &input_controller_; }
@@ -108,30 +82,16 @@ class EVENTS_OZONE_EVDEV_EXPORT EventFactoryEvdev
// Dispatch event via PlatformEventSource.
void DispatchUiEventTask(scoped_ptr<Event> event);
- // Open device at path & starting processing events (on UI thread).
- void AttachInputDevice(scoped_ptr<EventConverterEvdev> converter);
-
- // Close device at path (on UI thread).
- void DetachInputDevice(const base::FilePath& file_path);
-
- // Update observers on device changes.
- void NotifyDeviceChange(const EventConverterEvdev& converter);
- void NotifyKeyboardsUpdated();
- void NotifyTouchscreensUpdated();
-
int NextDeviceId();
- // Owned per-device event converters (by path).
- std::map<base::FilePath, EventConverterEvdev*> converters_;
-
// Used to uniquely identify input devices.
int last_device_id_;
// Interface for scanning & monitoring input devices.
DeviceManager* device_manager_; // Not owned.
- // Task runner for event dispatch.
- scoped_refptr<base::TaskRunner> ui_task_runner_;
+ // Factory for per-device objects.
+ scoped_ptr<InputDeviceFactoryEvdev> input_device_factory_;
// Dispatch callback for events.
EventDispatchCallback dispatch_callback_;
« no previous file with comments | « ui/events/ozone/BUILD.gn ('k') | ui/events/ozone/evdev/event_factory_evdev.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698