Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 861273002: Make TopSites a RefcountedKeyedService (Closed)

Created:
5 years, 11 months ago by sdefresne
Modified:
5 years, 11 months ago
Reviewers:
CC:
aandrey+blink_chromium.org, browser-components-watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-ntp_chromium.org, David Black, devtools-reviews_chromium.org, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, paulirish+reviews_chromium.org, pedrosimonetti+watch_chromium.org, pfeldman, samarth+watch_chromium.org, skanuj+watch_chromium.org, James Su, tfarina, vsevik, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TopSites a RefcountedKeyedService The lifetime of TopSites was tied to that of Profile, so make this explicit by turning TopSites into a RefcountedKeyedService. Patch-By: jitendra.ks@samsung.com BUG=435501

Patch Set 1 #

Patch Set 2 : Fix compilation on mac, win and android #

Patch Set 3 : Fix win compilation #

Patch Set 4 : Fix win compilation #

Patch Set 5 : Fix win compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -208 lines) Patch
M chrome/browser/android/dev_tools_manager_delegate_android.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/android/dev_tools_server.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/android/most_visited_sites.cc View 1 7 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider_unittest.cc View 8 chunks +18 lines, -9 lines 0 comments Download
M chrome/browser/devtools/browser_list_tabcontents_provider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/top_sites/top_sites_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/top_sites/top_sites_apitest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/history/chrome_history_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/top_sites.h View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/history/top_sites.cc View 1 chunk +10 lines, -13 lines 0 comments Download
A chrome/browser/history/top_sites_factory.h View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/history/top_sites_factory.cc View 1 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/browser/history/top_sites_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/history/top_sites_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/history/top_sites_impl_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 1 2 3 4 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/profiles/profile.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/search/instant_service.cc View 6 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/thumbnails/thumbnail_list_source.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/thumbnails/thumbnail_service_factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/thumbnails/thumbnail_service_impl.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/thumbnails/thumbnail_service_unittest.cc View 5 chunks +21 lines, -23 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 8 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_page_handler.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.h View 4 chunks +1 line, -8 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 7 chunks +43 lines, -26 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698