Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: chrome/browser/history/expire_history_backend_unittest.cc

Issue 861273002: Make TopSites a RefcountedKeyedService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix win compilation Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/chrome_history_client.h ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/expire_history_backend_unittest.cc
diff --git a/chrome/browser/history/expire_history_backend_unittest.cc b/chrome/browser/history/expire_history_backend_unittest.cc
index c63b465daea1b0c4587418409e8b537e2728d204..66398c109dc21375135eb4744b93a53c5c536d23 100644
--- a/chrome/browser/history/expire_history_backend_unittest.cc
+++ b/chrome/browser/history/expire_history_backend_unittest.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/history/expire_history_backend.h"
#include "chrome/browser/history/history_details.h"
#include "chrome/browser/history/top_sites.h"
+#include "chrome/browser/history/top_sites_factory.h"
#include "chrome/test/base/testing_profile.h"
#include "chrome/tools/profiles/thumbnail-inl.h"
#include "components/history/core/browser/history_backend_notifier.h"
@@ -107,7 +108,6 @@ class ExpireHistoryTest : public testing::Test,
scoped_ptr<HistoryDatabase> main_db_;
scoped_ptr<ThumbnailDatabase> thumb_db_;
TestingProfile profile_;
- scoped_refptr<TopSites> top_sites_;
// Time at the beginning of the test, so everybody agrees what "now" is.
const Time now_;
@@ -142,11 +142,9 @@ class ExpireHistoryTest : public testing::Test,
expirer_.SetDatabases(main_db_.get(), thumb_db_.get());
profile_.CreateTopSites();
profile_.BlockUntilTopSitesLoaded();
- top_sites_ = profile_.GetTopSites();
}
void TearDown() override {
- top_sites_ = NULL;
ClearLastNotifications();
@@ -230,9 +228,11 @@ void ExpireHistoryTest::AddExampleData(URLID url_ids[3], Time visit_times[4]) {
Time time;
GURL gurl;
- top_sites_->SetPageThumbnail(url_row1.url(), thumbnail, score);
- top_sites_->SetPageThumbnail(url_row2.url(), thumbnail, score);
- top_sites_->SetPageThumbnail(url_row3.url(), thumbnail, score);
+ scoped_refptr<history::TopSites> top_sites =
+ TopSitesFactory::GetForProfile(&profile_);
+ top_sites->SetPageThumbnail(url_row1.url(), thumbnail, score);
+ top_sites->SetPageThumbnail(url_row2.url(), thumbnail, score);
+ top_sites->SetPageThumbnail(url_row3.url(), thumbnail, score);
// Four visits.
VisitRow visit_row1;
@@ -312,7 +312,9 @@ bool ExpireHistoryTest::HasThumbnail(URLID url_id) {
return false;
GURL url = info.url();
scoped_refptr<base::RefCountedMemory> data;
- return top_sites_->GetPageThumbnail(url, false, &data);
+ scoped_refptr<history::TopSites> top_sites =
+ TopSitesFactory::GetForProfile(&profile_);
+ return top_sites->GetPageThumbnail(url, false, &data);
}
void ExpireHistoryTest::EnsureURLInfoGone(const URLRow& row, bool expired) {
« no previous file with comments | « chrome/browser/history/chrome_history_client.h ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698