Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3566)

Unified Diff: chrome/test/base/testing_profile.h

Issue 861273002: Make TopSites a RefcountedKeyedService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix win compilation Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chrome/test/base/testing_profile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/testing_profile.h
diff --git a/chrome/test/base/testing_profile.h b/chrome/test/base/testing_profile.h
index edb28debda7535d960bc880f40a6c27af1c53f8b..ca4c67416067fd5ff71fb7dc7bf3993e9864e212 100644
--- a/chrome/test/base/testing_profile.h
+++ b/chrome/test/base/testing_profile.h
@@ -13,6 +13,7 @@
#include "chrome/browser/profiles/profile.h"
#include "components/domain_reliability/clear_mode.h"
#include "components/keyed_service/content/browser_context_keyed_service_factory.h"
+#include "components/keyed_service/core/refcounted_keyed_service.h"
namespace content {
class MockResourceContext;
@@ -183,10 +184,6 @@ class TestingProfile : public Profile {
// loading.
void CreateTopSites();
- // Allows to set a test implementation |top_sites|. Testing profile owns
- // the reference and is responsible for releasing memory.
- void SetTopSites(history::TopSites* top_sites);
-
// Shuts down and nulls out the reference to TopSites.
void DestroyTopSites();
@@ -281,9 +278,6 @@ class TestingProfile : public Profile {
PrefService* GetPrefs() override;
- history::TopSites* GetTopSites() override;
- history::TopSites* GetTopSitesWithoutCreating() override;
-
net::URLRequestContextGetter* GetMediaRequestContext() override;
net::URLRequestContextGetter* GetMediaRequestContextForRenderProcess(
int renderer_child_id) override;
@@ -383,7 +377,6 @@ class TestingProfile : public Profile {
scoped_refptr<HostContentSettingsMap> host_content_settings_map_;
base::FilePath last_selected_directory_;
- scoped_refptr<history::TopSites> top_sites_; // For history and thumbnails.
#if defined(ENABLE_EXTENSIONS)
scoped_refptr<ExtensionSpecialStoragePolicy>
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chrome/test/base/testing_profile.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698