Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Side by Side Diff: chrome/browser/android/provider/chrome_browser_provider.h

Issue 861273002: Make TopSites a RefcountedKeyedService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix win compilation Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
6 #define CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 6 #define CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
7 7
8 #include "base/android/jni_weak_ref.h" 8 #include "base/android/jni_weak_ref.h"
9 #include "base/android/scoped_java_ref.h" 9 #include "base/android/scoped_java_ref.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 205
206 JavaObjectWeakGlobalRef weak_java_provider_; 206 JavaObjectWeakGlobalRef weak_java_provider_;
207 207
208 // Profile must outlive this object. 208 // Profile must outlive this object.
209 // 209 //
210 // BookmarkModel, HistoryService and history::TopSites lifetime is bound to 210 // BookmarkModel, HistoryService and history::TopSites lifetime is bound to
211 // the lifetime of Profile, they are safe to use as long as the Profile is 211 // the lifetime of Profile, they are safe to use as long as the Profile is
212 // alive. 212 // alive.
213 Profile* profile_; 213 Profile* profile_;
214 bookmarks::BookmarkModel* bookmark_model_; 214 bookmarks::BookmarkModel* bookmark_model_;
215 history::TopSites* top_sites_; 215 scoped_refptr<history::TopSites> top_sites_;
216 FaviconService* favicon_service_; 216 FaviconService* favicon_service_;
217 217
218 scoped_ptr<AndroidHistoryProviderService> service_; 218 scoped_ptr<AndroidHistoryProviderService> service_;
219 219
220 base::CancelableTaskTracker cancelable_task_tracker_; 220 base::CancelableTaskTracker cancelable_task_tracker_;
221 221
222 // Used to register/unregister notification observer. 222 // Used to register/unregister notification observer.
223 content::NotificationRegistrar notification_registrar_; 223 content::NotificationRegistrar notification_registrar_;
224 ScopedObserver<HistoryService, HistoryServiceObserver> 224 ScopedObserver<HistoryService, HistoryServiceObserver>
225 history_service_observer_; 225 history_service_observer_;
226 226
227 bool handling_extensive_changes_; 227 bool handling_extensive_changes_;
228 228
229 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserProvider); 229 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserProvider);
230 }; 230 };
231 231
232 #endif // CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 232 #endif // CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
OLDNEW
« no previous file with comments | « chrome/browser/android/most_visited_sites.cc ('k') | chrome/browser/android/provider/chrome_browser_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698