Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 856563002: Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize() (Closed)

Created:
5 years, 11 months ago by paulmeyer
Modified:
5 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize(), as per https://docs.google.com/a/google.com/document/d/1EJfmJSK0JJsxKptSRhepnsOOwvXJNv5nnJ1pZdjGDRQ/edit?usp=sharing. BUG=434226 Committed: https://crrev.com/1b61eb2416aa8b922134955d7a4ef412b45b3f9e Cr-Commit-Position: refs/heads/master@{#312651}

Patch Set 1 #

Total comments: 14

Patch Set 2 : Addressed comments. Added a bit more infrastructure than in the previous patch. #

Total comments: 22

Patch Set 3 : Addressed comments. #

Total comments: 4

Patch Set 4 : Addressed comment by kalman@. #

Total comments: 5

Patch Set 5 : Addressed comments by creis@. #

Patch Set 6 : Rebased. #

Patch Set 7 : Removed code from one non-essential function that was causing tests to fail. It will be re-added in… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -58 lines) Patch
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/browser_plugin_delegate.h View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 3 4 5 2 chunks +8 lines, -1 line 0 comments Download
M extensions/browser/extension_message_filter.h View 1 2 3 4 5 3 chunks +7 lines, -1 line 0 comments Download
M extensions/browser/extension_message_filter.cc View 1 2 3 4 5 4 chunks +15 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 1 2 3 4 5 2 chunks +11 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 2 3 4 5 6 chunks +33 lines, -7 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_find_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 2 3 4 5 13 chunks +15 lines, -15 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_permission_helper.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M extensions/common/extension_messages.h View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/common/guest_view/guest_view_constants.h View 1 chunk +10 lines, -1 line 0 comments Download
M extensions/common/guest_view/guest_view_constants.cc View 1 chunk +10 lines, -1 line 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.h View 1 2 3 4 3 chunks +11 lines, -0 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.cc View 1 2 3 4 5 6 3 chunks +15 lines, -2 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.h View 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h View 1 2 3 4 5 3 chunks +6 lines, -0 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 1 2 3 4 5 3 chunks +16 lines, -8 lines 0 comments Download
M extensions/renderer/resources/guest_view/guest_view.js View 1 2 6 chunks +41 lines, -3 lines 0 comments Download
M extensions/renderer/resources/guest_view/guest_view_container.js View 1 2 3 4 5 6 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (8 generated)
paulmeyer
+fsamuel@
5 years, 11 months ago (2015-01-15 20:47:44 UTC) #3
Fady Samuel
https://codereview.chromium.org/856563002/diff/20001/extensions/browser/extension_message_filter.cc File extensions/browser/extension_message_filter.cc (right): https://codereview.chromium.org/856563002/diff/20001/extensions/browser/extension_message_filter.cc#newcode301 extensions/browser/extension_message_filter.cc:301: std::string src, const reference https://codereview.chromium.org/856563002/diff/20001/extensions/browser/extension_message_filter.cc#newcode302 extensions/browser/extension_message_filter.cc:302: gfx::Size element_size, const ...
5 years, 11 months ago (2015-01-15 21:40:12 UTC) #4
paulmeyer
ptal https://codereview.chromium.org/856563002/diff/20001/extensions/browser/extension_message_filter.cc File extensions/browser/extension_message_filter.cc (right): https://codereview.chromium.org/856563002/diff/20001/extensions/browser/extension_message_filter.cc#newcode301 extensions/browser/extension_message_filter.cc:301: std::string src, On 2015/01/15 21:40:12, Fady Samuel wrote: ...
5 years, 11 months ago (2015-01-19 23:45:36 UTC) #5
Fady Samuel
lgtm + nits https://codereview.chromium.org/856563002/diff/40001/extensions/browser/guest_view/extension_options/extension_options_guest.cc File extensions/browser/guest_view/extension_options/extension_options_guest.cc (right): https://codereview.chromium.org/856563002/diff/40001/extensions/browser/guest_view/extension_options/extension_options_guest.cc#newcode143 extensions/browser/guest_view/extension_options/extension_options_guest.cc:143: DispatchEventToView(new extensions::GuestViewBase::Event( nit: remove extensions:: https://codereview.chromium.org/856563002/diff/40001/extensions/browser/guest_view/extension_options/extension_options_guest.cc#newcode163 ...
5 years, 11 months ago (2015-01-19 23:57:01 UTC) #6
Fady Samuel
https://codereview.chromium.org/856563002/diff/40001/extensions/renderer/resources/guest_view/guest_view_container.js File extensions/renderer/resources/guest_view/guest_view_container.js (right): https://codereview.chromium.org/856563002/diff/40001/extensions/renderer/resources/guest_view/guest_view_container.js#newcode29 extensions/renderer/resources/guest_view/guest_view_container.js:29: GuestViewInternalNatives.RegisterElementResizeCallback( On 2015/01/19 23:57:01, Fady Samuel wrote: > nit: ...
5 years, 11 months ago (2015-01-20 00:04:25 UTC) #7
paulmeyer
+creis@ for content/public/ +kalman@ for extension_message_filter.h/cc +kenrb@ for extension_messages.h https://codereview.chromium.org/856563002/diff/40001/extensions/browser/guest_view/extension_options/extension_options_guest.cc File extensions/browser/guest_view/extension_options/extension_options_guest.cc (right): https://codereview.chromium.org/856563002/diff/40001/extensions/browser/guest_view/extension_options/extension_options_guest.cc#newcode143 extensions/browser/guest_view/extension_options/extension_options_guest.cc:143: ...
5 years, 11 months ago (2015-01-20 00:24:38 UTC) #9
kenrb
ipc lgtm
5 years, 11 months ago (2015-01-20 15:12:23 UTC) #10
not at google - send to devlin
https://codereview.chromium.org/856563002/diff/60001/extensions/common/extension_messages.h File extensions/common/extension_messages.h (right): https://codereview.chromium.org/856563002/diff/60001/extensions/common/extension_messages.h#newcode804 extensions/common/extension_messages.h:804: base::DictionaryValue /* create_params */) why is this a dictionary ...
5 years, 11 months ago (2015-01-20 18:32:16 UTC) #11
paulmeyer
https://codereview.chromium.org/856563002/diff/60001/extensions/common/extension_messages.h File extensions/common/extension_messages.h (right): https://codereview.chromium.org/856563002/diff/60001/extensions/common/extension_messages.h#newcode804 extensions/common/extension_messages.h:804: base::DictionaryValue /* create_params */) On 2015/01/20 18:32:16, kalman wrote: ...
5 years, 11 months ago (2015-01-20 19:12:10 UTC) #12
not at google - send to devlin
https://codereview.chromium.org/856563002/diff/60001/extensions/common/extension_messages.h File extensions/common/extension_messages.h (right): https://codereview.chromium.org/856563002/diff/60001/extensions/common/extension_messages.h#newcode804 extensions/common/extension_messages.h:804: base::DictionaryValue /* create_params */) On 2015/01/20 19:12:09, Paul Meyer ...
5 years, 11 months ago (2015-01-20 19:30:09 UTC) #13
paulmeyer
ptal https://codereview.chromium.org/856563002/diff/60001/extensions/common/extension_messages.h File extensions/common/extension_messages.h (right): https://codereview.chromium.org/856563002/diff/60001/extensions/common/extension_messages.h#newcode804 extensions/common/extension_messages.h:804: base::DictionaryValue /* create_params */) On 2015/01/20 19:30:09, kalman ...
5 years, 11 months ago (2015-01-21 15:25:56 UTC) #14
Fady Samuel
still lgtm
5 years, 11 months ago (2015-01-21 15:36:31 UTC) #15
Fady Samuel
https://codereview.chromium.org/856563002/diff/80001/extensions/common/extension_messages.h File extensions/common/extension_messages.h (right): https://codereview.chromium.org/856563002/diff/80001/extensions/common/extension_messages.h#newcode821 extensions/common/extension_messages.h:821: ExtensionHostMsg_CreateMimeHandlerViewGuest_Params) nit: Add /* params */ as a virtual ...
5 years, 11 months ago (2015-01-21 17:57:06 UTC) #16
Charlie Reis
Only looked at content/, but two nits below. https://codereview.chromium.org/856563002/diff/80001/content/public/renderer/browser_plugin_delegate.h File content/public/renderer/browser_plugin_delegate.h (right): https://codereview.chromium.org/856563002/diff/80001/content/public/renderer/browser_plugin_delegate.h#newcode49 content/public/renderer/browser_plugin_delegate.h:49: virtual ...
5 years, 11 months ago (2015-01-21 18:18:53 UTC) #17
not at google - send to devlin
lgtm, thanks for tha
5 years, 11 months ago (2015-01-21 21:50:20 UTC) #18
paulmeyer
ptal https://codereview.chromium.org/856563002/diff/80001/content/public/renderer/browser_plugin_delegate.h File content/public/renderer/browser_plugin_delegate.h (right): https://codereview.chromium.org/856563002/diff/80001/content/public/renderer/browser_plugin_delegate.h#newcode49 content/public/renderer/browser_plugin_delegate.h:49: virtual void OnElementResize(const gfx::Size& old_size, On 2015/01/21 18:18:53, ...
5 years, 11 months ago (2015-01-21 22:07:44 UTC) #19
Charlie Reis
Thanks. content/ LGTM.
5 years, 11 months ago (2015-01-21 22:19:18 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856563002/100001
5 years, 11 months ago (2015-01-21 22:20:58 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/15955) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/16080) mac_chromium_rel_ng ...
5 years, 11 months ago (2015-01-21 22:26:50 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856563002/120001
5 years, 11 months ago (2015-01-22 01:40:44 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/24575)
5 years, 11 months ago (2015-01-22 03:08:03 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856563002/140001
5 years, 11 months ago (2015-01-22 16:19:51 UTC) #30
commit-bot: I haz the power
Committed patchset #7 (id:140001)
5 years, 11 months ago (2015-01-22 19:13:31 UTC) #31
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 19:14:30 UTC) #32
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/1b61eb2416aa8b922134955d7a4ef412b45b3f9e
Cr-Commit-Position: refs/heads/master@{#312651}

Powered by Google App Engine
This is Rietveld 408576698