Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: extensions/renderer/guest_view/extensions_guest_view_container.cc

Issue 856563002: Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed code from one non-essential function that was causing tests to fail. It will be re-added in… Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/extensions_guest_view_container.cc
diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.cc b/extensions/renderer/guest_view/extensions_guest_view_container.cc
index c546c3a407f5775b35fef57e14e775900b970481..3a5359f922699bf80f2cb9afff93182921920cac 100644
--- a/extensions/renderer/guest_view/extensions_guest_view_container.cc
+++ b/extensions/renderer/guest_view/extensions_guest_view_container.cc
@@ -147,7 +147,8 @@ ExtensionsGuestViewContainer::ExtensionsGuestViewContainer(
content::RenderFrame* render_frame)
: GuestViewContainer(render_frame),
ready_(false),
- destruction_isolate_(nullptr) {
+ destruction_isolate_(nullptr),
+ element_resize_isolate_(nullptr) {
}
ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() {
@@ -168,7 +169,7 @@ ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() {
v8::Context::Scope context_scope(context);
blink::WebScopedMicrotaskSuppression suppression;
- callback->Call(context->Global(), 0, nullptr);
+ callback->Call(context->Global(), 0 /* argc */, nullptr);
}
ExtensionsGuestViewContainer* ExtensionsGuestViewContainer::FromID(
@@ -191,6 +192,18 @@ void ExtensionsGuestViewContainer::RegisterDestructionCallback(
destruction_isolate_ = isolate;
}
+void ExtensionsGuestViewContainer::RegisterElementResizeCallback(
+ v8::Handle<v8::Function> callback,
+ v8::Isolate* isolate) {
+ element_resize_callback_.reset(callback);
+ element_resize_isolate_ = isolate;
+}
+
+void ExtensionsGuestViewContainer::DidResizeElement(const gfx::Size& old_size,
+ const gfx::Size& new_size) {
+ // TODO(paulmeyer): Call the |element_resize_callback_| callback here.
+}
+
bool ExtensionsGuestViewContainer::OnMessageReceived(
const IPC::Message& message) {
OnHandleCallback(message);

Powered by Google App Engine
This is Rietveld 408576698