Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize()

extensions/renderer/guest_view/extensions_guest_view_container.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/guest_view/extensions_guest_view_container.h"
 
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_view.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/guest_view/guest_view_constants.h"
@@ skipping 144 matching lines @@
   v8::HandleScope handle_scope(destruction_isolate_);
   v8::Handle<v8::Function> callback =
       destruction_callback_.NewHandle(destruction_isolate_);
   v8::Handle<v8::Context> context = callback->CreationContext();
   if (context.IsEmpty())
     return;
 
   v8::Context::Scope context_scope(context);
   blink::WebScopedMicrotaskSuppression suppression;
 
-  callback->Call(context->Global(), 0, nullptr);
+  callback->Call(context->Global(), 0 /* argc */, nullptr);
 }
 
 ExtensionsGuestViewContainer* ExtensionsGuestViewContainer::FromID(
     int element_instance_id) {
   ExtensionsGuestViewContainerMap* guest_view_containers =
       g_guest_view_container_map.Pointer();
   ExtensionsGuestViewContainerMap::iterator it =
       guest_view_containers->find(element_instance_id);
   return it == guest_view_containers->end() ? NULL : it->second;
 }
 
 void ExtensionsGuestViewContainer::IssueRequest(linked_ptr<Request> request) {
   EnqueueRequest(request);
   PerformPendingRequest();
 }
 
 void ExtensionsGuestViewContainer::RegisterDestructionCallback(
     v8::Handle<v8::Function> callback,
     v8::Isolate* isolate) {
   destruction_callback_.reset(callback);
   destruction_isolate_ = isolate;
 }
 
+void ExtensionsGuestViewContainer::RegisterElementResizeCallback(
+    v8::Handle<v8::Function> callback,
+    v8::Isolate* isolate) {
+  element_resize_callback_.reset(callback);
+  element_resize_isolate_ = isolate;

[Fady Samuel, 2015/01/15 21:40:12]

Initialize this in the constructor's initializer list.

[paulmeyer, 2015/01/19 23:45:35]

Done.

+}
+
+void ExtensionsGuestViewContainer::OnElementResize(const gfx::Size& old_size,
+                                                   const gfx::Size& new_size) {
+  // Call the element resize callback, if one is registered.
+  if (element_resize_callback_.IsEmpty())
+    return;
+
+  v8::HandleScope handle_scope(element_resize_isolate_);
+  v8::Handle<v8::Function> callback =
+      element_resize_callback_.NewHandle(element_resize_isolate_);
+  v8::Handle<v8::Context> context = callback->CreationContext();
+  if (context.IsEmpty())
+    return;
+
+  const int argc = 4;
+  v8::Handle<v8::Value> argv[argc] = {
+    v8::Integer::New(element_resize_isolate_, old_size.width()),
+    v8::Integer::New(element_resize_isolate_, old_size.height()),
+    v8::Integer::New(element_resize_isolate_, new_size.width()),
+    v8::Integer::New(element_resize_isolate_, new_size.height())
+  };
+
+  v8::Context::Scope context_scope(context);
+  blink::WebScopedMicrotaskSuppression suppression;
+
+  callback->Call(context->Global(), argc, argv);
+}
+
 bool ExtensionsGuestViewContainer::OnMessageReceived(
     const IPC::Message& message) {
   OnHandleCallback(message);
   return true;
 }
 
 void ExtensionsGuestViewContainer::SetElementInstanceID(
     int element_instance_id) {
   GuestViewContainer::SetElementInstanceID(element_instance_id);
 
@@ skipping 32 matching lines @@
 }
 
 void ExtensionsGuestViewContainer::HandlePendingResponseCallback(
     const IPC::Message& message) {
   CHECK(pending_response_.get());
   linked_ptr<Request> pending_response(pending_response_.release());
   pending_response->HandleResponse(message);
 }
 
 }  // namespace extensions