Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 856563002: Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed code from one non-essential function that was causing tests to fail. It will be re-added in… Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
index c2d42933c5eddedb604ab5bb48028e142bcde9a4..62bbf189bf56a7245e5408fde2dd327a72b712bd 100644
--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
@@ -32,6 +32,11 @@ GuestViewInternalCustomBindings::GuestViewInternalCustomBindings(
"RegisterDestructionCallback",
base::Bind(&GuestViewInternalCustomBindings::RegisterDestructionCallback,
base::Unretained(this)));
+ RouteFunction(
+ "RegisterElementResizeCallback",
+ base::Bind(
+ &GuestViewInternalCustomBindings::RegisterElementResizeCallback,
+ base::Unretained(this)));
}
void GuestViewInternalCustomBindings::AttachGuest(
@@ -135,4 +140,27 @@ void GuestViewInternalCustomBindings::RegisterDestructionCallback(
args.GetReturnValue().Set(v8::Boolean::New(context()->isolate(), true));
}
+void GuestViewInternalCustomBindings::RegisterElementResizeCallback(
+ const v8::FunctionCallbackInfo<v8::Value>& args) {
+ // There are two parameters.
+ CHECK(args.Length() == 2);
+ // Element Instance ID.
+ CHECK(args[0]->IsInt32());
+ // Callback function.
+ CHECK(args[1]->IsFunction());
+
+ int element_instance_id = args[0]->Int32Value();
+ // An element instance ID uniquely identifies a ExtensionsGuestViewContainer
+ // within a RenderView.
+ ExtensionsGuestViewContainer* guest_view_container =
+ ExtensionsGuestViewContainer::FromID(element_instance_id);
+ if (!guest_view_container)
+ return;
+
+ guest_view_container->RegisterElementResizeCallback(
+ args[1].As<v8::Function>(), args.GetIsolate());
+
+ args.GetReturnValue().Set(v8::Boolean::New(context()->isolate(), true));
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698