Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 855473002: initial preroll api (Closed)

Created:
5 years, 11 months ago by reed2
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : now with impl #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -3 lines) Patch
M gyp/core.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkImage.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkPicture.h View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A src/core/SkPicturePreroll.cpp View 1 2 3 4 1 chunk +162 lines, -0 lines 0 comments Download
M src/core/SkPictureShader.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPictureShader.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/image/SkImage_Base.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 2 3 4 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
reed2
5 years, 11 months ago (2015-01-14 23:10:35 UTC) #2
bsalomon
On 2015/01/14 23:10:35, reed2 wrote: I like it
5 years, 11 months ago (2015-01-15 14:37:25 UTC) #3
robertphillips
lgtm. May need some dox re the space in which the srcBounds resides.
5 years, 11 months ago (2015-01-15 16:51:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855473002/100001
5 years, 11 months ago (2015-01-25 03:35:26 UTC) #6
reed2
now with impl -- PTAL
5 years, 11 months ago (2015-01-25 03:36:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855473002/120001
5 years, 11 months ago (2015-01-25 18:26:19 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-25 18:34:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/96a857ef5a40b3d0751ec9ebaaa96d9f20b82b21

Powered by Google App Engine
This is Rietveld 408576698