Source/bindings/v8/ExceptionMessages.cpp - Issue 85263002: Improve handling of dictionary conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ExceptionMessages.cpp

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have conversion methods take a context argument; elaborate error msgs further. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ExceptionMessages.cpp

diff --git a/Source/bindings/v8/ExceptionMessages.cpp b/Source/bindings/v8/ExceptionMessages.cpp

index 8108578ebc08ff6780f4587492f08aa86f2a71a1..613fa571b68ca394f17877c4bbc436168e2bbd4a 100644

--- a/Source/bindings/v8/ExceptionMessages.cpp

+++ b/Source/bindings/v8/ExceptionMessages.cpp

@@ -60,6 +60,11 @@ String ExceptionMessages::failedToDelete(const String& property, const String& t

return "Failed to delete the '" + property + "' property from '" + type + "': " + detail;

}

+String ExceptionMessages::incorrectPropertyType(const String& property, const String& detail)

+ return "The '" + property + "' property " + detail;

String ExceptionMessages::notAnArrayTypeArgumentOrValue(int argumentIndex)

{

String kind;