Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: Source/bindings/v8/ExceptionMessages.cpp

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have conversion methods take a context argument; elaborate error msgs further. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 String ExceptionMessages::failedToSet(const String& property, const String& type , const String& detail) 53 String ExceptionMessages::failedToSet(const String& property, const String& type , const String& detail)
54 { 54 {
55 return "Failed to set the '" + property + "' property on '" + type + "': " + detail; 55 return "Failed to set the '" + property + "' property on '" + type + "': " + detail;
56 } 56 }
57 57
58 String ExceptionMessages::failedToDelete(const String& property, const String& t ype, const String& detail) 58 String ExceptionMessages::failedToDelete(const String& property, const String& t ype, const String& detail)
59 { 59 {
60 return "Failed to delete the '" + property + "' property from '" + type + "' : " + detail; 60 return "Failed to delete the '" + property + "' property from '" + type + "' : " + detail;
61 } 61 }
62 62
63 String ExceptionMessages::incorrectPropertyType(const String& property, const St ring& detail)
64 {
65 return "The '" + property + "' property " + detail;
66 }
67
63 String ExceptionMessages::notAnArrayTypeArgumentOrValue(int argumentIndex) 68 String ExceptionMessages::notAnArrayTypeArgumentOrValue(int argumentIndex)
64 { 69 {
65 String kind; 70 String kind;
66 if (argumentIndex) // method argument 71 if (argumentIndex) // method argument
67 kind = ordinalNumber(argumentIndex) + " argument"; 72 kind = ordinalNumber(argumentIndex) + " argument";
68 else // value, e.g. attribute setter 73 else // value, e.g. attribute setter
69 kind = "value provided"; 74 kind = "value provided";
70 return "The " + kind + " is neither an array, nor does it have indexed prope rties."; 75 return "The " + kind + " is neither an array, nor does it have indexed prope rties.";
71 } 76 }
72 77
(...skipping 27 matching lines...) Expand all
100 break; 105 break;
101 case 3: 106 case 3:
102 if (number % 100 != 13) 107 if (number % 100 != 13)
103 suffix = "rd"; 108 suffix = "rd";
104 break; 109 break;
105 } 110 }
106 return String::number(number) + suffix; 111 return String::number(number) + suffix;
107 } 112 }
108 113
109 } // namespace WebCore 114 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698