Source/bindings/v8/ExceptionMessages.h - Issue 85263002: Improve handling of dictionary conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ExceptionMessages.h

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have conversion methods take a context argument; elaborate error msgs further. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ExceptionMessages.h

diff --git a/Source/bindings/v8/ExceptionMessages.h b/Source/bindings/v8/ExceptionMessages.h

index dd41c631297fd0600fdcb60c4cd6ac3bc37a88d2..eb7421eec672b41be4fbc8f2dc669b4a1e2b79ea 100644

--- a/Source/bindings/v8/ExceptionMessages.h

+++ b/Source/bindings/v8/ExceptionMessages.h

@@ -42,6 +42,7 @@ public:

static String failedToGet(const String& property, const String& type, const String& detail);

static String failedToSet(const String& property, const String& type, const String& detail);

static String failedToDelete(const String& property, const String& type, const String& detail);

+ static String incorrectPropertyType(const String& property, const String& detail);

// If > 0, the argument index that failed type check (1-indexed.)

// If == 0, a (non-argument) value (e.g., a setter) failed the same check.