Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: Source/bindings/v8/V8Binding.h

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have conversion methods take a context argument; elaborate error msgs further. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8Binding.h
diff --git a/Source/bindings/v8/V8Binding.h b/Source/bindings/v8/V8Binding.h
index 76250156a929c0716e6ee940f1b6fe4e139031cd..c5ae26529128d645f9cf77caa560e3a8c6628898 100644
--- a/Source/bindings/v8/V8Binding.h
+++ b/Source/bindings/v8/V8Binding.h
@@ -33,7 +33,6 @@
#define V8Binding_h
#include "bindings/v8/DOMWrapperWorld.h"
-#include "bindings/v8/Dictionary.h"
#include "bindings/v8/ExceptionMessages.h"
#include "bindings/v8/V8BindingMacros.h"
#include "bindings/v8/V8PerIsolateData.h"
@@ -312,7 +311,7 @@ namespace WebCore {
enum IntegerConversionConfiguration {
NormalConversion,
EnforceRange,
- // FIXME: Implement Clamp
+ Clamp
};
// Convert a value to a 8-bit signed integer. The conversion fails if the
@@ -470,14 +469,6 @@ namespace WebCore {
}
};
- template<>
- struct NativeValueTraits<Dictionary> {
- static inline Dictionary nativeValue(const v8::Handle<v8::Value>& value, v8::Isolate* isolate)
- {
- return Dictionary(value, isolate);
- }
- };
-
// Converts a JavaScript value to an array as per the Web IDL specification:
// http://www.w3.org/TR/2012/CR-WebIDL-20120419/#es-array
template <class T, class V8T>

Powered by Google App Engine
This is Rietveld 408576698