Componentize HistoryDatabase

Componentize HistoryDatabase

Remove dependency on //content from HistoryDatabase by passing the
DownloadInterruptReason value to HistoryDatabase constructor.

Introduce HistoryDatabaseParams to allow easier forwarding of the
HistoryDatabase parameters from HistoryServiceFactory to the db.

Move //components/history/core/{android => browser/android} to avoid
having a circular dependency between history_core_browser and
history_core_android.

Remove history_core_android (//components/core/android) targets.

BUG=370850
TBR=bauerb@chromium.org
TBR=pkasting@chromium.org
TBR=sky@chromium.org
TBR=tburkard@chromium.org
TBR=jcivelli@chromium.org
TBR=robertshield@chromium.org

Committed: https://crrev.com/46129158888f7a765fc7cf28da16ae9dd159e0fb
Cr-Commit-Position: refs/heads/master@{#312243}

[sdefresne, 2015-01-15 21:38:11]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2015-01-15 21:38:12]

Please take a look.

[droger, 2015-01-20 09:49:01]

https://codereview.chromium.org/849323002/diff/1/components/history/content/b...
File components/history/content/browser/history_database_helper.h (right):

https://codereview.chromium.org/849323002/diff/1/components/history/content/b...
components/history/content/browser/history_database_helper.h:16:
HistoryDatabaseParams HistoryDatabaseParamsForPath(
Why is this is a separate file? Could it be another constructor in
HistoryDatabaseParams?

[sdefresne, 2015-01-20 10:28:50]

Move all files to //components/history/core/browser/android as discussed
offline.

Please take another look.

https://codereview.chromium.org/849323002/diff/1/components/history/content/b...
File components/history/content/browser/history_database_helper.h (right):

https://codereview.chromium.org/849323002/diff/1/components/history/content/b...
components/history/content/browser/history_database_helper.h:16:
HistoryDatabaseParams HistoryDatabaseParamsForPath(
On 2015/01/20 09:49:00, droger wrote:
> Why is this is a separate file? Could it be another constructor in
> HistoryDatabaseParams?

Because the implementation depends on //content and HistoryDatabaseParams cannot
depends on //content.

[droger, 2015-01-20 10:41:11]

lgtm

[sdefresne, 2015-01-20 18:15:35]

sdefresne@chromium.org changed reviewers:
+ bauerb@chromium.org

[sdefresne, 2015-01-20 18:15:59]

sdefresne@chromium.org changed reviewers:
+ pkasting@chromium.org

[sdefresne, 2015-01-20 18:16:52]

sdefresne@chromium.org changed reviewers:
+ tburkard@chromium.org

[sdefresne, 2015-01-20 18:17:42]

sdefresne@chromium.org changed reviewers:
+ jcivelli@chromium.org

[sdefresne, 2015-01-20 18:18:16]

sdefresne@chromium.org changed reviewers:
+ robertshield@chromium.org

[sdefresne, 2015-01-20 18:19:00]

sdefresne@chromium.org changed reviewers:
+ sky@chromium.org

[sdefresne, 2015-01-20 18:24:00]

TBR-ing OWNERS of affected changes since they are:
- simple mechanical changes due to file being moved
- obsolete dependency on a deleted target (BUILD.gn)
- updating client code after API change in test files

OWNERS
- bauerb for //chrome/browser/android/provider
- pkasting for //chrome/browser/autocomplete
- tburkard for //chrome/browser/prerender
- jcivelli for //chrome/test/base/testing_profile.h
- robershield for //chrome/browser/safe_browsing/incident_reporting
- sky for //chrome/browser/BUILD.gn & //chrome/browser/predictors

[sdefresne, 2015-01-20 19:18:08]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-01-20 19:19:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/849323002/100001

[commit-bot: I haz the power, 2015-01-20 19:25:11]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-01-20 19:25:59]

Patchset 6 (id:??) landed as
https://crrev.com/46129158888f7a765fc7cf28da16ae9dd159e0fb
Cr-Commit-Position: refs/heads/master@{#312243}