Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: chrome/browser/history/android/android_urls_database_unittest.cc

Issue 849323002: Componentize HistoryDatabase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android compilation Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/history/core/android/android_urls_database.h" 5 #include "components/history/core/browser/android/android_urls_database.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "chrome/browser/history/history_database.h"
11 #include "chrome/common/chrome_constants.h" 10 #include "chrome/common/chrome_constants.h"
12 #include "chrome/common/chrome_paths.h" 11 #include "chrome/common/chrome_paths.h"
13 #include "chrome/test/base/testing_profile.h" 12 #include "chrome/test/base/testing_profile.h"
14 #include "components/history/core/browser/history_constants.h" 13 #include "components/history/core/browser/history_constants.h"
14 #include "components/history/core/browser/history_database.h"
15 #include "components/history/core/test/history_unittest_base.h" 15 #include "components/history/core/test/history_unittest_base.h"
16 #include "components/history/core/test/test_history_database.h"
16 17
17 namespace history { 18 namespace history {
18 19
19 class AndroidURLsMigrationTest : public HistoryUnitTestBase { 20 class AndroidURLsMigrationTest : public HistoryUnitTestBase {
20 public: 21 public:
21 AndroidURLsMigrationTest() { 22 AndroidURLsMigrationTest() {}
22 }
23 virtual ~AndroidURLsMigrationTest() {} 23 virtual ~AndroidURLsMigrationTest() {}
24 24
25 protected: 25 protected:
26 virtual void SetUp() { 26 virtual void SetUp() {
27 profile_.reset(new TestingProfile); 27 profile_.reset(new TestingProfile);
28 28
29 base::FilePath data_path; 29 base::FilePath data_path;
30 ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &data_path)); 30 ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &data_path));
31 data_path = data_path.AppendASCII("History"); 31 data_path = data_path.AppendASCII("History");
32 32
33 history_db_name_ = profile_->GetPath().Append(kHistoryFilename); 33 history_db_name_ = profile_->GetPath().Append(kHistoryFilename);
34 // Set up history as they would be before migration. 34 // Set up history as they would be before migration.
35 ASSERT_NO_FATAL_FAILURE( 35 ASSERT_NO_FATAL_FAILURE(
36 ExecuteSQLScript(data_path.AppendASCII("history.21.sql"), 36 ExecuteSQLScript(data_path.AppendASCII("history.21.sql"),
37 history_db_name_)); 37 history_db_name_));
38 } 38 }
39 39
40 protected: 40 protected:
41 base::FilePath history_db_name_; 41 base::FilePath history_db_name_;
42 scoped_ptr<TestingProfile> profile_; 42 scoped_ptr<TestingProfile> profile_;
43 }; 43 };
44 44
45 // Disabled as this does not correctly set up all the tables so that migration 45 // Disabled as this does not correctly set up all the tables so that migration
46 // fails. See http://crbug.com/175460 . 46 // fails. See http://crbug.com/175460 .
47 TEST_F(AndroidURLsMigrationTest, DISABLED_MigrateToVersion22) { 47 TEST_F(AndroidURLsMigrationTest, DISABLED_MigrateToVersion22) {
48 HistoryDatabase db; 48 TestHistoryDatabase db;
49 ASSERT_EQ(sql::INIT_OK, db.Init(history_db_name_)); 49 ASSERT_EQ(sql::INIT_OK, db.Init(history_db_name_));
50 // Migration has done. 50 // Migration has done.
51 // The column of previous table shouldn't exist. 51 // The column of previous table shouldn't exist.
52 EXPECT_FALSE(db.GetDB().DoesColumnExist("android_urls", "bookmark")); 52 EXPECT_FALSE(db.GetDB().DoesColumnExist("android_urls", "bookmark"));
53 sql::Statement statement(db.GetDB().GetUniqueStatement( 53 sql::Statement statement(db.GetDB().GetUniqueStatement(
54 "SELECT id, url_id, raw_url FROM android_urls ORDER BY id ASC")); 54 "SELECT id, url_id, raw_url FROM android_urls ORDER BY id ASC"));
55 ASSERT_TRUE(statement.Step()); 55 ASSERT_TRUE(statement.Step());
56 EXPECT_EQ(1, statement.ColumnInt64(0)); 56 EXPECT_EQ(1, statement.ColumnInt64(0));
57 EXPECT_EQ("http://google.com/", statement.ColumnString(2)); 57 EXPECT_EQ("http://google.com/", statement.ColumnString(2));
58 EXPECT_EQ(1, statement.ColumnInt64(1)); 58 EXPECT_EQ(1, statement.ColumnInt64(1));
59 59
60 ASSERT_TRUE(statement.Step()); 60 ASSERT_TRUE(statement.Step());
61 EXPECT_EQ(4, statement.ColumnInt64(0)); 61 EXPECT_EQ(4, statement.ColumnInt64(0));
62 EXPECT_EQ("www.google.com/", statement.ColumnString(2)); 62 EXPECT_EQ("www.google.com/", statement.ColumnString(2));
63 EXPECT_EQ(3, statement.ColumnInt64(1)); 63 EXPECT_EQ(3, statement.ColumnInt64(1));
64 64
65 EXPECT_FALSE(statement.Step()); 65 EXPECT_FALSE(statement.Step());
66 } 66 }
67 67
68 } // namespace history 68 } // namespace history
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698