components/history/content/browser/history_database_helper.h - Issue 849323002: Componentize HistoryDatabase

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/history/content/browser/history_database_helper.h

Issue 849323002: Componentize HistoryDatabase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_HISTORY_CONTENT_BROWSER_HISTORY_DATABASE_HELPER_H_

	6 #define COMPONENTS_HISTORY_CONTENT_BROWSER_HISTORY_DATABASE_HELPER_H_

	7

	8 namespace base {

	9 class FilePath;

	10 }

	11

	12 namespace history {

	13

	14 struct HistoryDatabaseParams;

	15

	16 HistoryDatabaseParams HistoryDatabaseParamsForPath(
	droger 2015/01/20 09:49:00 Why is this is a separate file? Could it be anothe Why is this is a separate file? Could it be another constructor in HistoryDatabaseParams? sdefresne 2015/01/20 10:28:50 Because the implementation depends on //content an Show quoted text On 2015/01/20 09:49:00, droger wrote: > Why is this is a separate file? Could it be another constructor in > HistoryDatabaseParams? Because the implementation depends on //content and HistoryDatabaseParams cannot depends on //content.
	17 const base::FilePath& history_dir);

	18

	19 } // namespace history

	20

	21 #endif // COMPONENTS_HISTORY_CONTENT_BROWSER_HISTORY_DATABASE_HELPER_H_

OLD	NEW