Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2088)

Unified Diff: chrome/browser/history/history_service.h

Issue 849323002: Componentize HistoryDatabase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android compilation Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_querying_unittest.cc ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index fc9dd80426c91a700ee5bc9e82b9994aed6090ab..0501f9b73de47b4a57eb6af0722548000b573316 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -62,6 +62,7 @@ namespace history {
class HistoryBackend;
class HistoryClient;
class HistoryDatabase;
+struct HistoryDatabaseParams;
class HistoryDBTask;
class HistoryQueryTest;
class HistoryServiceObserver;
@@ -102,8 +103,8 @@ class HistoryService : public content::NotificationObserver,
// Initializes the history service, returning true on success. On false, do
// not call any other functions. The given directory will be used for storing
// the history files.
- bool Init(const base::FilePath& history_dir) {
- return Init(history_dir, false);
+ bool Init(const history::HistoryDatabaseParams& history_database_params) {
+ return Init(false, history_database_params);
}
// Triggers the backend to load if it hasn't already, and then returns whether
@@ -566,7 +567,8 @@ class HistoryService : public content::NotificationObserver,
// Low-level Init(). Same as the public version, but adds a |no_db| parameter
// that is only set by unittests which causes the backend to not init its DB.
- bool Init(const base::FilePath& history_dir, bool no_db);
+ bool Init(bool no_db,
+ const history::HistoryDatabaseParams& history_database_params);
// Called by the HistoryURLProvider class to schedule an autocomplete, it
// will be called back on the internal history thread with the history
« no previous file with comments | « chrome/browser/history/history_querying_unittest.cc ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698