Cleanup most pylint errors in json_schema_compiler.

Cleanup most pylint errors in json_schema_compiler.

Committed: https://crrev.com/b179975134a3302cda4473240abcb74ecb45a6a0
Cr-Commit-Position: refs/heads/master@{#311761}

[Lei Zhang, 2015-01-14 22:39:53]

thestig@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2015-01-14 22:44:42]

lgtm.

Does this mean we can make it a presubmit too?

https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/c...
File tools/json_schema_compiler/compiler.py (right):

https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/c...
tools/json_schema_compiler/compiler.py:88: filename =
os.path.split(file_path)[1]
maybe change it to

_, filename = ...

then? I prefer that when it's explicitly a tuple.

https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/i...
File tools/json_schema_compiler/idl_schema.py (right):

https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/i...
tools/json_schema_compiler/idl_schema.py:393: properties =
Member(member).process(self.callbacks)[1]
ditto

https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/p...
File tools/json_schema_compiler/preview.py (right):

https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/p...
tools/json_schema_compiler/preview.py:288: file_ext =
os.path.splitext(full_path)[1]
ditto

https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/s...
File tools/json_schema_compiler/schema_loader.py (right):

https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/s...
tools/json_schema_compiler/schema_loader.py:84: schema_extension =
os.path.splitext(schema)[1]
ditto

[Lei Zhang, 2015-01-14 23:05:28]

On 2015/01/14 22:44:42, kalman wrote:
> lgtm.
> 
> Does this mean we can make it a presubmit too?

There's still a few errors left and I didn't lint any test files. But
eventually, yes.

>
https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/c...
> File tools/json_schema_compiler/compiler.py (right):
> 
>
https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/c...
> tools/json_schema_compiler/compiler.py:88: filename =
> os.path.split(file_path)[1]
> maybe change it to
> 
> _, filename = ...

I don't care much either way. Are there guidelines somewhere that says to prefer
"_, foo"? Just curious.

[not at google - send to devlin, 2015-01-14 23:06:59]

https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/c...
File tools/json_schema_compiler/compiler.py (right):

https://codereview.chromium.org/849103005/diff/1/tools/json_schema_compiler/c...
tools/json_schema_compiler/compiler.py:88: filename =
os.path.split(file_path)[1]
On 2015/01/14 22:44:41, kalman wrote:
> maybe change it to
> 
> _, filename = ...
> 
> then? I prefer that when it's explicitly a tuple.

no idea. I just like to be explicit when something is a tuple not a list.

[Lei Zhang, 2015-01-15 21:31:50]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-01-15 21:37:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/849103005/20001

[commit-bot: I haz the power, 2015-01-15 23:19:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-15 23:20:43]

Patchset 2 (id:??) landed as
https://crrev.com/b179975134a3302cda4473240abcb74ecb45a6a0
Cr-Commit-Position: refs/heads/master@{#311761}