tools/json_schema_compiler/model.py - Issue 849103005: Cleanup most pylint errors in json_schema_compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/model.py

Issue 849103005: Cleanup most pylint errors in json_schema_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/model.py

diff --git a/tools/json_schema_compiler/model.py b/tools/json_schema_compiler/model.py

index 16530e7f465b2e523958c8e00afdc8c1e6f652d1..7745dcc4fcc1cf1624de72a57ea495ff1d43ecda 100644

--- a/tools/json_schema_compiler/model.py

+++ b/tools/json_schema_compiler/model.py

@@ -304,8 +304,8 @@ class Function(object):

def GeneratePropertyFromParam(p):

return Property(self, p['name'], p, namespace, origin)

- self.filters = [GeneratePropertyFromParam(filter)

- for filter in json.get('filters', [])]

+ self.filters = [GeneratePropertyFromParam(filter_instance)

+ for filter_instance in json.get('filters', [])]

callback_param = None

for param in json.get('parameters', []):

if param.get('type') == 'function':

« no previous file with comments | « tools/json_schema_compiler/idl_schema.py ('k') | tools/json_schema_compiler/preview.py » ('j') | no next file with comments »