tools/json_schema_compiler/preview.py - Issue 849103005: Cleanup most pylint errors in json_schema_compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/preview.py

Issue 849103005: Cleanup most pylint errors in json_schema_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/preview.py

diff --git a/tools/json_schema_compiler/preview.py b/tools/json_schema_compiler/preview.py

index 050af9637efbe9ca7eb5d5d6c5819e23c5a4162e..aceb575305b600e7800a887e24c867105c412f08 100755

--- a/tools/json_schema_compiler/preview.py

+++ b/tools/json_schema_compiler/preview.py

@@ -201,7 +201,6 @@ updateEverything();

namespace)

# Generate code

- cpp_namespace = 'generated_api_schemas'

if file_ext == '.h':

cpp_code = (h_generator.HGenerator(type_generator)

.Generate(namespace).Render())

@@ -286,7 +285,7 @@ updateEverything();

# Each file under path/

for filename in sorted(os.listdir(path)):

full_path = os.path.join(path, filename)

- (file_root, file_ext) = os.path.splitext(full_path)

+ _, file_ext = os.path.splitext(full_path)

if os.path.isdir(full_path) and not full_path.endswith('.xcodeproj'):

html.Append('<li><a href="/%s/">%s/</a>' % (full_path, filename))

elif file_ext in ['.json', '.idl']:

« no previous file with comments | « tools/json_schema_compiler/model.py ('k') | tools/json_schema_compiler/schema_loader.py » ('j') | no next file with comments »