Cleanup most pylint errors in json_schema_compiler.

tools/json_schema_compiler/idl_schema.py

 #! /usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import itertools
 import json
 import os.path
 import re
 import sys
@@ skipping 253 matching lines @@
     elif self.typeref == 'ArrayBuffer':
       properties['type'] = 'binary'
       properties['isInstanceOf'] = 'ArrayBuffer'
     elif self.typeref == 'FileEntry':
       properties['type'] = 'object'
       properties['isInstanceOf'] = 'FileEntry'
       if 'additionalProperties' not in properties:
         properties['additionalProperties'] = OrderedDict()
       properties['additionalProperties']['type'] = 'any'
     elif self.parent.GetPropertyLocal('Union'):
-      choices = []
       properties['choices'] = [Typeref(node.GetProperty('TYPEREF'),
                                        node,
                                        OrderedDict()).process(callbacks)
                                for node in self.parent.GetChildren()
                                if node.cls == 'Option']
     elif self.typeref is None:
       properties['type'] = 'function'
     else:
       if self.typeref in callbacks:
         # Do not override name and description if they are already specified.
@@ skipping 11 matching lines @@
 
 class Enum(object):
   '''
   Given an IDL Enum node, converts into a Python dictionary that the JSON
   schema compiler expects to see.
   '''
   def __init__(self, enum_node):
     self.node = enum_node
     self.description = ''
 
-  def process(self, callbacks):
+  def process(self):
     enum = []
     for node in self.node.GetChildren():
       if node.cls == 'EnumItem':
         enum_value = {'name': node.GetName()}
         for child in node.GetChildren():
           if child.cls == 'Comment':
             enum_value['description'] = ProcessComment(child.GetName())[0]
           else:
             raise ValueError('Did not process %s %s' % (child.cls, child))
         enum.append(enum_value)
       elif node.cls == 'Comment':
         self.description = ProcessComment(node.GetName())[0]
       else:
         sys.exit('Did not process %s %s' % (node.cls, node))
     result = {'id' : self.node.GetName(),
               'description': self.description,
               'type': 'string',
               'enum': enum}
     for property_name in (
         'inline_doc', 'noinline_doc', 'nodoc', 'cpp_enum_prefix_override',):
       if self.node.GetProperty(property_name):
         result[property_name] = self.node.GetProperty(property_name)
     if self.node.GetProperty('deprecated'):
-        result[deprecated] = self.node.GetProperty('deprecated')
+      result['deprecated'] = self.node.GetProperty('deprecated')
     return result
 
 
 class Namespace(object):
   '''
   Given an IDLNode representing an IDL namespace, converts into a Python
   dictionary that the JSON schema compiler expects to see.
   '''
 
   def __init__(self,
@@ skipping 21 matching lines @@
       if node.cls == 'Dictionary':
         self.types.append(Dictionary(node).process(self.callbacks))
       elif node.cls == 'Callback':
         k, v = Member(node).process(self.callbacks)
         self.callbacks[k] = v
       elif node.cls == 'Interface' and node.GetName() == 'Functions':
         self.functions = self.process_interface(node)
       elif node.cls == 'Interface' and node.GetName() == 'Events':
         self.events = self.process_interface(node)
       elif node.cls == 'Enum':
-        self.types.append(Enum(node).process(self.callbacks))
+        self.types.append(Enum(node).process())
       else:
         sys.exit('Did not process %s %s' % (node.cls, node))
     if self.compiler_options is not None:
       compiler_options = self.compiler_options
     else:
       compiler_options = {}
     return {'namespace': self.namespace.GetName(),
             'description': self.description,
             'nodoc': self.nodoc,
             'types': self.types,
             'functions': self.functions,
             'internal': self.internal,
             'events': self.events,
             'platforms': self.platforms,
             'compiler_options': compiler_options,
             'deprecated': self.deprecated}
 
   def process_interface(self, node):
     members = []
     for member in node.GetChildren():
       if member.cls == 'Member':
-        name, properties = Member(member).process(self.callbacks)
+        properties = Member(member).process(self.callbacks)[1]

[not at google - send to devlin, 2015/01/14 22:44:41]

ditto

         members.append(properties)
     return members
 
 
 class IDLSchema(object):
   '''
   Given a list of IDLNodes and IDLAttributes, converts into a Python list
   of api_defs that the JSON schema compiler expects to see.
   '''
 
@@ skipping 74 matching lines @@
       print json.dumps(schema, indent=2)
   else:
     contents = sys.stdin.read()
     idl = idl_parser.IDLParser().ParseData(contents, '<stdin>')
     schema = IDLSchema(idl).process()
     print json.dumps(schema, indent=2)
 
 
 if __name__ == '__main__':
   Main()