Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 846943002: Improve BindBufferBase/BindBufferRange and a few other commands. (Closed)

Created:
5 years, 11 months ago by Zhenyao Mo
Modified:
5 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, bajones, no sievers, Ken Russell (switch to Gerrit), vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve BindBufferBase/BindBufferRange and a few other commands. 1) The original plan was to push out a quick WebGL 2 prototype, so Nacl code path is not considered, i.e., we didn't consider the case that we could bind to a buffer ID that hasn't been created through GenBuffers. This CL addresses this gap. 2) This CL fixed a bug that on the service side, when we receive an invalid client ID, we need to generate an GL error instead of passing down to call underlying APIs. BUG=429053 TEST=gpu_unittests R=piman@chromium.org Committed: https://crrev.com/ee3fa9866a01dc2fcd1e3beb188c683ba4d79e8b Cr-Commit-Position: refs/heads/master@{#311137}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -67 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 7 chunks +64 lines, -21 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 3 chunks +46 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 3 chunks +16 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/share_group.h View 2 chunks +20 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/share_group.cc View 3 chunks +76 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/context_group.h View 2 chunks +1 line, -18 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 9 chunks +44 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 1 chunk +16 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Zhenyao Mo
piman: this addresses several comments you made in previous CLs. Please take a look. Others: ...
5 years, 11 months ago (2015-01-12 20:57:48 UTC) #2
piman
LGTM, thanks!
5 years, 11 months ago (2015-01-12 22:11:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846943002/40001
5 years, 11 months ago (2015-01-12 22:26:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 11 months ago (2015-01-12 23:07:18 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 23:08:00 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee3fa9866a01dc2fcd1e3beb188c683ba4d79e8b
Cr-Commit-Position: refs/heads/master@{#311137}

Powered by Google App Engine
This is Rietveld 408576698