Improve BindBufferBase/BindBufferRange and a few other commands.

gpu/command_buffer/client/gles2_implementation.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A class to emulate GLES2 over command buffers.
 
 #include "gpu/command_buffer/client/gles2_implementation.h"
 
 #include <GLES2/gl2ext.h>
 #include <GLES2/gl2extchromium.h>
@@ skipping 2677 matching lines @@
         this, target, buffer_id, &GLES2Implementation::BindBufferStub);
   }
 }
 
 void GLES2Implementation::BindBufferStub(GLenum target, GLuint buffer) {
   helper_->BindBuffer(target, buffer);
   if (share_group_->bind_generates_resource())
     helper_->CommandBufferHelper::Flush();
 }
 
+void GLES2Implementation::BindBufferBaseHelper(
+    GLenum target, GLuint index, GLuint buffer_id) {
+  // TODO(zmo): See note #1 above.
+  // TODO(zmo): There's a bug here. If the target or index is invalid the ID
+  // will not be used even though it's marked it as used here.
+  GetIdHandler(id_namespaces::kBuffers)->MarkAsUsedForBind(
+      this, target, index, buffer_id, &GLES2Implementation::BindBufferBaseStub);
+}
+
+void GLES2Implementation::BindBufferBaseStub(
+    GLenum target, GLuint index, GLuint buffer) {
+  helper_->BindBufferBase(target, index, buffer);
+  if (share_group_->bind_generates_resource())
+    helper_->CommandBufferHelper::Flush();
+}
+
+void GLES2Implementation::BindBufferRangeHelper(
+    GLenum target, GLuint index, GLuint buffer_id,
+    GLintptr offset, GLsizeiptr size) {
+  // TODO(zmo): See note #1 above.
+  // TODO(zmo): There's a bug here. If an arguments is invalid the ID will not
+  // be used even though it's marked it as used here.
+  GetIdHandler(id_namespaces::kBuffers)->MarkAsUsedForBind(
+      this, target, index, buffer_id, offset, size,
+      &GLES2Implementation::BindBufferRangeStub);
+}
+
+void GLES2Implementation::BindBufferRangeStub(
+    GLenum target, GLuint index, GLuint buffer,
+    GLintptr offset, GLsizeiptr size) {
+  // TODO(zmo): uncomment the below call once the helper function is added.
+  // helper_->BindBufferRange(target, index, buffer, offset, size);
+  if (share_group_->bind_generates_resource())
+    helper_->CommandBufferHelper::Flush();
+}
+
 void GLES2Implementation::BindFramebufferHelper(
     GLenum target, GLuint framebuffer) {
   // TODO(gman): See note #1 above.
   bool changed = false;
   switch (target) {
     case GL_FRAMEBUFFER:
       if (bound_framebuffer_ != framebuffer ||
           bound_read_framebuffer_ != framebuffer) {
         bound_framebuffer_ = framebuffer;
         bound_read_framebuffer_ = framebuffer;
@@ skipping 62 matching lines @@
   }
 }
 
 void GLES2Implementation::BindRenderbufferStub(GLenum target,
                                                GLuint renderbuffer) {
   helper_->BindRenderbuffer(target, renderbuffer);
   if (share_group_->bind_generates_resource())
     helper_->CommandBufferHelper::Flush();
 }
 
+void GLES2Implementation::BindSamplerHelper(GLuint unit,
+                                            GLuint sampler) {
+  helper_->BindSampler(unit, sampler);
+}
+
 void GLES2Implementation::BindTextureHelper(GLenum target, GLuint texture) {
   // TODO(gman): See note #1 above.
   // TODO(gman): Change this to false once we figure out why it's failing
   //     on daisy.
   bool changed = true;
   TextureUnit& unit = texture_units_[active_texture_unit_];
   switch (target) {
     case GL_TEXTURE_2D:
       if (unit.bound_texture_2d != texture) {
         unit.bound_texture_2d = texture;
@@ skipping 23 matching lines @@
         this, target, texture, &GLES2Implementation::BindTextureStub);
   }
 }
 
 void GLES2Implementation::BindTextureStub(GLenum target, GLuint texture) {
   helper_->BindTexture(target, texture);
   if (share_group_->bind_generates_resource())
     helper_->CommandBufferHelper::Flush();
 }
 
+void GLES2Implementation::BindTransformFeedbackHelper(
+    GLenum target, GLuint transformfeedback) {
+  helper_->BindTransformFeedback(target, transformfeedback);
+}
+
 void GLES2Implementation::BindVertexArrayOESHelper(GLuint array) {
   // TODO(gman): See note #1 above.
   bool changed = false;
   if (vertex_array_object_manager_->BindVertexArray(array, &changed)) {
     if (changed) {
       // Unlike other BindXXXHelpers we don't call MarkAsUsedForBind
       // because unlike other resources VertexArrayObject ids must
       // be generated by GenVertexArrays. A random id to Bind will not
       // generate a new object.
       helper_->BindVertexArrayOES(array);
@@ skipping 1523 matching lines @@
   return false;
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/client/gles2_implementation_impl_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu