Improve BindBufferBase/BindBufferRange and a few other commands.

gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is auto-generated from
 // gpu/command_buffer/build_gles2_cmd_buffer.py
 // It's formatted by clang-format using chromium coding style:
 //    clang-format -i -style=chromium filename
 // DO NOT EDIT!
 
@@ skipping 41 matching lines @@
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::BindBufferBase& c =
       *static_cast<const gles2::cmds::BindBufferBase*>(cmd_data);
   (void)c;
   GLenum target = static_cast<GLenum>(c.target);
   GLuint index = static_cast<GLuint>(c.index);
   GLuint buffer = c.buffer;
-  group_->GetBufferServiceId(buffer, &buffer);
+  if (!group_->GetBufferServiceId(buffer, &buffer)) {
+    if (!group_->bind_generates_resource()) {
+      LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glBindBufferBase",
+                         "invalid buffer id");
+      return error::kNoError;
+    }
+    GLuint client_id = buffer;
+    glGenBuffersARB(1, &buffer);
+    CreateBuffer(client_id, buffer);
+  }
   glBindBufferBase(target, index, buffer);
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleBindFramebuffer(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::BindFramebuffer& c =
       *static_cast<const gles2::cmds::BindFramebuffer*>(cmd_data);
   (void)c;
@@ skipping 25 matching lines @@
 
 error::Error GLES2DecoderImpl::HandleBindSampler(uint32_t immediate_data_size,
                                                  const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::BindSampler& c =
       *static_cast<const gles2::cmds::BindSampler*>(cmd_data);
   (void)c;
   GLuint unit = static_cast<GLuint>(c.unit);
   GLuint sampler = c.sampler;
-  group_->GetSamplerServiceId(sampler, &sampler);
+  if (!group_->GetSamplerServiceId(sampler, &sampler)) {
+    LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glBindSampler",
+                       "invalid sampler id");
+    return error::kNoError;
+  }
   glBindSampler(unit, sampler);
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleBindTexture(uint32_t immediate_data_size,
                                                  const void* cmd_data) {
   const gles2::cmds::BindTexture& c =
       *static_cast<const gles2::cmds::BindTexture*>(cmd_data);
   (void)c;
   GLenum target = static_cast<GLenum>(c.target);
   GLuint texture = c.texture;
   if (!validators_->texture_bind_target.IsValid(target)) {
     LOCAL_SET_GL_ERROR_INVALID_ENUM("glBindTexture", target, "target");
     return error::kNoError;
   }
   DoBindTexture(target, texture);
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleBindTransformFeedback(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::BindTransformFeedback& c =
       *static_cast<const gles2::cmds::BindTransformFeedback*>(cmd_data);
   (void)c;
   GLenum target = static_cast<GLenum>(c.target);
   GLuint transformfeedback = c.transformfeedback;
-  group_->GetTransformFeedbackServiceId(transformfeedback, &transformfeedback);
+  if (!group_->GetTransformFeedbackServiceId(transformfeedback,
+                                             &transformfeedback)) {
+    LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glBindTransformFeedback",
+                       "invalid transformfeedback id");
+    return error::kNoError;
+  }
   glBindTransformFeedback(target, transformfeedback);
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleBlendColor(uint32_t immediate_data_size,
                                                 const void* cmd_data) {
   const gles2::cmds::BlendColor& c =
       *static_cast<const gles2::cmds::BlendColor*>(cmd_data);
   (void)c;
   GLclampf red = static_cast<GLclampf>(c.red);
@@ skipping 1305 matching lines @@
       c.params_shm_id, c.params_shm_offset, Result::ComputeSize(num_values));
   GLfloat* params = result ? result->GetData() : NULL;
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetSamplerParameterfv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
-  group_->GetSamplerServiceId(sampler, &sampler);
+  if (!group_->GetSamplerServiceId(sampler, &sampler)) {
+    LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glGetSamplerParameterfv",
+                       "invalid sampler id");
+    return error::kNoError;
+  }
   glGetSamplerParameterfv(sampler, pname, params);
   GLenum error = glGetError();
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
   } else {
     LOCAL_SET_GL_ERROR(error, "GetSamplerParameterfv", "");
   }
   return error::kNoError;
 }
 
@@ skipping 14 matching lines @@
       c.params_shm_id, c.params_shm_offset, Result::ComputeSize(num_values));
   GLint* params = result ? result->GetData() : NULL;
   if (params == NULL) {
     return error::kOutOfBounds;
   }
   LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER("GetSamplerParameteriv");
   // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
-  group_->GetSamplerServiceId(sampler, &sampler);
+  if (!group_->GetSamplerServiceId(sampler, &sampler)) {
+    LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glGetSamplerParameteriv",
+                       "invalid sampler id");
+    return error::kNoError;
+  }
   glGetSamplerParameteriv(sampler, pname, params);
   GLenum error = glGetError();
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
   } else {
     LOCAL_SET_GL_ERROR(error, "GetSamplerParameteriv", "");
   }
   return error::kNoError;
 }
 
@@ skipping 377 matching lines @@
   const gles2::cmds::IsSampler& c =
       *static_cast<const gles2::cmds::IsSampler*>(cmd_data);
   (void)c;
   GLuint sampler = c.sampler;
   typedef cmds::IsSampler::Result Result;
   Result* result_dst = GetSharedMemoryAs<Result*>(
       c.result_shm_id, c.result_shm_offset, sizeof(*result_dst));
   if (!result_dst) {
     return error::kOutOfBounds;
   }
-  group_->GetSamplerServiceId(sampler, &sampler);
-  *result_dst = glIsSampler(sampler);
+  *result_dst = group_->GetSamplerServiceId(sampler, &sampler);
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleIsShader(uint32_t immediate_data_size,
                                               const void* cmd_data) {
   const gles2::cmds::IsShader& c =
       *static_cast<const gles2::cmds::IsShader*>(cmd_data);
   (void)c;
   GLuint shader = c.shader;
   typedef cmds::IsShader::Result Result;
@@ skipping 30 matching lines @@
   const gles2::cmds::IsTransformFeedback& c =
       *static_cast<const gles2::cmds::IsTransformFeedback*>(cmd_data);
   (void)c;
   GLuint transformfeedback = c.transformfeedback;
   typedef cmds::IsTransformFeedback::Result Result;
   Result* result_dst = GetSharedMemoryAs<Result*>(
       c.result_shm_id, c.result_shm_offset, sizeof(*result_dst));
   if (!result_dst) {
     return error::kOutOfBounds;
   }
-  group_->GetTransformFeedbackServiceId(transformfeedback, &transformfeedback);
-  *result_dst = glIsTransformFeedback(transformfeedback);
+  *result_dst = group_->GetTransformFeedbackServiceId(transformfeedback,
+                                                      &transformfeedback);
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleLineWidth(uint32_t immediate_data_size,
                                                const void* cmd_data) {
   const gles2::cmds::LineWidth& c =
       *static_cast<const gles2::cmds::LineWidth*>(cmd_data);
   (void)c;
   GLfloat width = static_cast<GLfloat>(c.width);
   if (width <= 0.0f || base::IsNaN(width)) {
@@ skipping 126 matching lines @@
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::SamplerParameterf& c =
       *static_cast<const gles2::cmds::SamplerParameterf*>(cmd_data);
   (void)c;
   GLuint sampler = c.sampler;
   GLenum pname = static_cast<GLenum>(c.pname);
   GLfloat param = static_cast<GLfloat>(c.param);
-  group_->GetSamplerServiceId(sampler, &sampler);
+  if (!group_->GetSamplerServiceId(sampler, &sampler)) {
+    LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glSamplerParameterf",
+                       "invalid sampler id");
+    return error::kNoError;
+  }
   glSamplerParameterf(sampler, pname, param);
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleSamplerParameterfvImmediate(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::SamplerParameterfvImmediate& c =
@@ skipping 22 matching lines @@
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::SamplerParameteri& c =
       *static_cast<const gles2::cmds::SamplerParameteri*>(cmd_data);
   (void)c;
   GLuint sampler = c.sampler;
   GLenum pname = static_cast<GLenum>(c.pname);
   GLint param = static_cast<GLint>(c.param);
-  group_->GetSamplerServiceId(sampler, &sampler);
+  if (!group_->GetSamplerServiceId(sampler, &sampler)) {
+    LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glSamplerParameteri",
+                       "invalid sampler id");
+    return error::kNoError;
+  }
   glSamplerParameteri(sampler, pname, param);
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleSamplerParameterivImmediate(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::SamplerParameterivImmediate& c =
@@ skipping 2398 matching lines @@
           state_.ignore_cached_state) {
         framebuffer_state_.clear_state_dirty = true;
       }
       return false;
     default:
       NOTREACHED();
       return false;
   }
 }
 #endif  // GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_AUTOGEN_H_