gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc - Issue 846943002: Improve BindBufferBase/BindBufferRange and a few other commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

Issue 846943002: Improve BindBufferBase/BindBufferRange and a few other commands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_autogen.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

index 2e7f4fcf70e068d6ff2c5a8f5ce304572f04068f..db1c62fc6842d5daba8a9ccbc72baa48fe03ccf6 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

@@ -41,15 +41,6 @@ class GLES2DecoderTest1 : public GLES2DecoderTestBase {

INSTANTIATE_TEST_CASE_P(Service, GLES2DecoderTest1, ::testing::Bool());

template <>

-void GLES2DecoderTestBase::SpecializedSetup<cmds::BindBufferBase, 0>(

- bool valid) {

- if (valid) {

- // TODO(zmo): This might affect the states of later tests.

- group_->AddBufferId(client_buffer_id_, kServiceBufferId);

- }

-};

-template <>

void GLES2DecoderTestBase::SpecializedSetup<cmds::GenerateMipmap, 0>(

bool valid) {

DoBindTexture(GL_TEXTURE_2D, client_texture_id_, kServiceTextureId);