Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 845623002: Remove SkTileGrid (except for TileGridInfo). (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : kill gridSupported #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -677 lines) Patch
M bench/PicturePlaybackBench.cpp View 4 chunks +1 line, -6 lines 0 comments Download
M dm/DMCpuGMTask.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M dm/DMQuiltTask.h View 1 chunk +0 lines, -1 line 0 comments Download
M dm/DMQuiltTask.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M gm/gmmain.cpp View 5 chunks +3 lines, -45 lines 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkBBHFactory.h View 2 chunks +2 lines, -10 lines 0 comments Download
M samplecode/SamplePictFile.cpp View 6 chunks +5 lines, -19 lines 0 comments Download
M src/core/SkBBHFactory.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
D src/core/SkTileGrid.h View 1 chunk +0 lines, -51 lines 0 comments Download
D src/core/SkTileGrid.cpp View 1 chunk +0 lines, -188 lines 0 comments Download
M tests/PictureBBHTest.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M tests/RecordingXfermodeTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
D tests/TileGridTest.cpp View 1 chunk +0 lines, -254 lines 0 comments Download
M tools/PictureRenderer.h View 7 chunks +2 lines, -23 lines 0 comments Download
M tools/PictureRenderer.cpp View 9 chunks +8 lines, -10 lines 0 comments Download
M tools/PictureRenderingFlags.cpp View 1 6 chunks +0 lines, -21 lines 0 comments Download
M tools/bbh_shootout.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/bench_pictures_cfg_helper.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mtklein
Needs to land after https://codereview.chromium.org/841173003/
5 years, 11 months ago (2015-01-08 21:42:49 UTC) #2
robertphillips
lgtm
5 years, 11 months ago (2015-01-09 14:25:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845623002/1
5 years, 11 months ago (2015-01-09 14:28:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/1423)
5 years, 11 months ago (2015-01-09 14:31:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845623002/20001
5 years, 11 months ago (2015-01-09 14:32:41 UTC) #9
reed1
lgtm
5 years, 11 months ago (2015-01-09 14:36:49 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 14:41:51 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/703dd2ed187b9788c5bb0f2d313f2d07695603d6

Powered by Google App Engine
This is Rietveld 408576698