Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 844733003: Use VisibilityState enum and move WebPageVisibilityState to public/platform. (Closed)

Created:
5 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 11 months ago
Reviewers:
Mike West
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, rwlbuis, serviceworker-reviews, sof, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@sw_enum_stuff
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use VisibilityState enum and move WebPageVisibilityState to public/platform. Actually, the enum will stay in public/web/ but a copy is in public/platform until Chromium gets updated. This is the first CL of a three-sided CL: - <this> - https://codereview.chromium.org/806703004 - https://codereview.chromium.org/831483003 Use VisibilityState enum in Document and SW's WindowClient. BUG=447212 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188151

Patch Set 1 #

Patch Set 2 : set pageVisibilityState #

Patch Set 3 : SWContainer uses pageVisibilityState #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M Source/core/dom/Document.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/Document.idl View 2 chunks +4 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerWindowClient.h View 2 chunks +4 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp View 3 chunks +10 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/WindowClient.idl View 2 chunks +4 lines, -1 line 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 2 chunks +1 line, -1 line 0 comments Download
A + public/platform/WebPageVisibilityState.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M public/platform/WebServiceWorkerClientsInfo.h View 2 chunks +4 lines, -2 lines 0 comments Download
M public/web/WebView.h View 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebViewClient.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mlamouri (slow - plz ping)
5 years, 11 months ago (2015-01-08 18:56:33 UTC) #2
mlamouri (slow - plz ping)
Mike, I've updated the CL description to include the other parts. PTAL.
5 years, 11 months ago (2015-01-09 11:11:13 UTC) #3
Mike West
LGTM.
5 years, 11 months ago (2015-01-09 11:40:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844733003/40001
5 years, 11 months ago (2015-01-09 11:46:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/41509)
5 years, 11 months ago (2015-01-09 13:12:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844733003/40001
5 years, 11 months ago (2015-01-09 13:39:21 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 14:23:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188151

Powered by Google App Engine
This is Rietveld 408576698