Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 806703004: [ServiceWorker] Use WebPageVisibilityState in ClientInfo. (Closed)

Created:
5 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Use WebPageVisibilityState in ClientInfo. That means setting pageVisibilityState in WebServiceWorkerClientInfo and use page_visibility_state instead of visibilyt_state in ServiceWorkerInfo. In addition, this CL uses WebPageVisibilityState.h from public/platform/ instead of public/web/. This is part of a three-sided CL: - https://codereview.chromium.org/844733003/ - <this> - https://codereview.chromium.org/831483003 BUG=447212 Committed: https://crrev.com/3c578ba82c786e4c76f934ee234fa2576372ee3c Cr-Commit-Position: refs/heads/master@{#310988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/request_extra_data.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M content/common/content_param_traits_macros.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/service_worker/service_worker_types.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/browser/resource_request_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/test_render_frame_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mlamouri (slow - plz ping)
jochen@, please review changes in: - chrome/browser/DEPS nasko@, please review changes in: - * mkwst@, ...
5 years, 11 months ago (2015-01-09 11:15:09 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-09 13:05:45 UTC) #5
nasko
LGTM
5 years, 11 months ago (2015-01-09 18:27:00 UTC) #6
Mike West
LGTM3.
5 years, 11 months ago (2015-01-09 22:21:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806703004/1
5 years, 11 months ago (2015-01-10 17:21:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-10 19:02:43 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 19:03:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c578ba82c786e4c76f934ee234fa2576372ee3c
Cr-Commit-Position: refs/heads/master@{#310988}

Powered by Google App Engine
This is Rietveld 408576698