Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 831483003: [ServiceWorker] Use pageVisibilityState instead of visibilityState. (Closed)

Created:
5 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 11 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@page_visibility_state
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Use pageVisibilityState instead of visibilityState. It means that the WebPageVisibilityState enum is now used by the Client instead of an arbitrary string. It guarantees that the interface is now using the VisibilityState enum as requested by the specification. This is part of a three-way CLs. This CL is cleaning-up code from the first CL: - https://codereview.chromium.org/844733003/ - https://codereview.chromium.org/806703004 - <this> BUG=447212 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -63 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerWindowClient.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M public/platform/WebServiceWorkerClientsInfo.h View 1 chunk +1 line, -2 lines 0 comments Download
D public/web/WebPageVisibilityState.h View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mlamouri (slow - plz ping)
5 years, 11 months ago (2015-01-09 11:15:55 UTC) #2
Mike West
LGTM.
5 years, 11 months ago (2015-01-09 11:41:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831483003/1
5 years, 11 months ago (2015-01-10 19:48:00 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 20:59:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188187

Powered by Google App Engine
This is Rietveld 408576698