Source/modules/serviceworkers/ServiceWorkerWindowClient.h - Issue 844733003: Use VisibilityState enum and move WebPageVisibilityState to public/platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerWindowClient.h

Issue 844733003: Use VisibilityState enum and move WebPageVisibilityState to public/platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_enum_stuff

Patch Set: SWContainer uses pageVisibilityState Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerWindowClient.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerWindowClient.h b/Source/modules/serviceworkers/ServiceWorkerWindowClient.h

index 89f892b895ebc010922e434d02d8a8da9683a5ad..85bc114629fb408f3b7b83df454f76416b2078c3 100644

--- a/Source/modules/serviceworkers/ServiceWorkerWindowClient.h

+++ b/Source/modules/serviceworkers/ServiceWorkerWindowClient.h

@@ -21,7 +21,7 @@ public:

~ServiceWorkerWindowClient() override;

// WindowClient.idl

- String visibilityState() const { return m_visibilityState; }

+ String visibilityState() const;

bool focused() const { return m_isFocused; }

String frameType() const;

ScriptPromise focus(ScriptState*);

@@ -31,7 +31,10 @@ public:

private:

explicit ServiceWorkerWindowClient(const WebServiceWorkerClientInfo&);

+ // FIXME: remove m_visibilityState when m_pageVisibilityState will be used

+ // by Chromium.

String m_visibilityState;

+ WebPageVisibilityState m_pageVisibilityState;

bool m_isFocused;

WebURLRequest::FrameType m_frameType;

};