Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 843773002: Only match style from element's TreeScope for normal rules. (Closed)

Created:
5 years, 11 months ago by rune
Modified:
5 years, 11 months ago
Reviewers:
esprehn, hayato
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Only match style from element's TreeScope for normal rules. We collected all scoped resolvers up to the document resolver while collecting normal style rules. That was necessary for <style scoped>, but now that all scoping is done through shadow roots, only boundary crossing rules can match from other author style scopes. Those rules are handled through the global TreeBoundaryCrossingRules. Instead, collect using the ScopedStyleResolver for the element's tree scope if present. The need for CascadeScope disappears, so it's been removed. There is an exception for custom pseudo elements and VTT elements (styled through ::cue) since those rules are crossing a shadow boundary, yet not handled as part of boundary crossing rules. I chose to do the special handling instead of start adding them to the boundary crossing rules since the boundary crossing rule handling is about to change as part of 401359 anyway, and the special handling is safer since it's closer to the previous behavior. R=hayato@chromium.org BUG=401359 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188292

Patch Set 1 #

Patch Set 2 : Fixed custom pseudo and ::cue regressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -90 lines) Patch
A LayoutTests/fast/dom/shadow/custom-pseudo-scope.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/custom-pseudo-scope-expected.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/css/ElementRuleCollector.h View 5 chunks +7 lines, -12 lines 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 8 chunks +15 lines, -19 lines 0 comments Download
M Source/core/css/TreeBoundaryCrossingRules.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 3 chunks +38 lines, -49 lines 0 comments Download

Messages

Total messages: 20 (4 generated)
rune
ptal
5 years, 11 months ago (2015-01-08 13:44:10 UTC) #1
rune
On 2015/01/08 at 13:44:10, rune wrote: > ptal Regressed: media/track/css-cue-for-video-in-shadow-2.html
5 years, 11 months ago (2015-01-08 14:16:58 UTC) #2
rune
On 2015/01/08 at 14:16:58, rune wrote: > On 2015/01/08 at 13:44:10, rune wrote: > > ...
5 years, 11 months ago (2015-01-08 23:53:43 UTC) #3
hayato
This looks similar to https://codereview.chromium.org/451983002/, as you might be already aware of that. On 2015/01/08 ...
5 years, 11 months ago (2015-01-09 08:36:52 UTC) #4
rune
On 2015/01/09 at 08:36:52, hayato wrote: > This looks similar to https://codereview.chromium.org/451983002/, as you might ...
5 years, 11 months ago (2015-01-09 10:21:10 UTC) #5
rune
Adding esprehn@ since he did https://codereview.chromium.org/585683002/ That CL does a little bit more refactoring than ...
5 years, 11 months ago (2015-01-09 11:30:28 UTC) #7
rune
On 2015/01/09 at 11:30:28, rune wrote: > Adding esprehn@ since he did https://codereview.chromium.org/585683002/ > > ...
5 years, 11 months ago (2015-01-09 15:55:33 UTC) #8
rune
hayato@ could you PTAL?
5 years, 11 months ago (2015-01-13 07:46:31 UTC) #9
hayato
Yeah, let me take a look soon. Sorry for the late response. Monday was a ...
5 years, 11 months ago (2015-01-13 08:46:53 UTC) #10
rune
On 2015/01/13 at 08:46:53, hayato wrote: > Yeah, let me take a look soon. > ...
5 years, 11 months ago (2015-01-13 08:51:56 UTC) #11
hayato
LGTM
5 years, 11 months ago (2015-01-13 10:40:57 UTC) #12
rune
On 2015/01/13 at 10:40:57, hayato wrote: > LGTM thanks!
5 years, 11 months ago (2015-01-13 10:44:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843773002/20001
5 years, 11 months ago (2015-01-13 10:45:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/45908)
5 years, 11 months ago (2015-01-13 12:23:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843773002/20001
5 years, 11 months ago (2015-01-13 12:33:27 UTC) #19
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 13:18:09 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188292

Powered by Google App Engine
This is Rietveld 408576698