Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 451983002: Remove cascadeScope (Closed)

Created:
6 years, 4 months ago by kochi
Modified:
6 years, 3 months ago
Reviewers:
esprehn, tasak
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove cascadeScope As <style scoped> is removed, |cascadeScope| parameters which was used for determining which style will be applied is no longer necessary. Only cascadeOrder is enough. BUG=none TEST=no new layout test failure CLOSED IN FAVOR OF https://codereview.chromium.org/577423002

Patch Set 1 #

Patch Set 2 : rebase. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -40 lines) Patch
M Source/core/css/ElementRuleCollector.h View 1 2 5 chunks +6 lines, -11 lines 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 1 2 8 chunks +13 lines, -17 lines 0 comments Download
M Source/core/css/TreeBoundaryCrossingRules.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tasak
I'm just curious: compareRules is: static inline bool compareRules(const MatchedRule& matchedRule1, const MatchedRule& matchedRule2) { ...
6 years, 4 months ago (2014-08-08 07:00:26 UTC) #1
kochi
+esprehn
6 years, 3 months ago (2014-09-19 01:38:58 UTC) #3
esprehn
On 2014/09/19 at 01:38:58, kochi wrote: > +esprehn I took this over in https://codereview.chromium.org/577423002, not ...
6 years, 3 months ago (2014-09-19 01:41:40 UTC) #4
kochi
On 2014/09/19 01:41:40, esprehn wrote: > On 2014/09/19 at 01:38:58, kochi wrote: > > +esprehn ...
6 years, 3 months ago (2014-09-19 01:46:49 UTC) #5
tasak
6 years, 3 months ago (2014-09-19 02:31:04 UTC) #6
On 2014/09/19 01:46:49, Takayoshi Kochi wrote:
> On 2014/09/19 01:41:40, esprehn wrote:
> > On 2014/09/19 at 01:38:58, kochi wrote:
> > > +esprehn
> > 
> > I took this over in https://codereview.chromium.org/577423002, not sure
about
> > tasak@'s comment but given that cascadeOrder is always zero now I don't
think
> > we've lost anything here.
> 
> Please do so, once https://codereview.chromium.org/585683002/ gets committed.
> I agree that cascadeOrder corresponds to <style scoped>, so now no user uses
> the value.

Do you have any plan about removing / deprecating webkit-prefixed custom pseudo,
e.g. input::-webkit-slider-thumb?

If not, we should apply input::-webkit-slider-thumb in a parent treescope to
current treescope.

Since TreeScope == CascadeScope, we cannot remove CascadeScope, I think.

Powered by Google App Engine
This is Rietveld 408576698