Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 585683002: Stop traversing up the tree looking for ScopedStyleResolvers. (Closed)

Created:
6 years, 3 months ago by esprehn
Modified:
5 years, 9 months ago
Reviewers:
dglazkov, kochi, ojan
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Project:
blink
Visibility:
Public.

Description

Stop traversing up the tree looking for ScopedStyleResolvers. There's no reason to collect resolvers up the tree, only the element's scope can ever contain matching rules except for tree boundary crossing rules or :host/:host-context rules and we deal with those separately. This also exposes that CascadeScope is dead code and we can remove it. BUG=372083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -68 lines) Patch
M Source/core/css/ElementRuleCollector.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 3 chunks +14 lines, -66 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
esprehn
This patch depends on https://codereview.chromium.org/581663003
6 years, 3 months ago (2014-09-18 23:09:52 UTC) #1
esprehn
6 years, 3 months ago (2014-09-19 01:32:36 UTC) #3
tasak
On 2014/09/19 01:32:36, esprehn wrote: I think, this patch should consider -webkit prefixed custom pseudo, ...
6 years, 3 months ago (2014-09-19 02:28:27 UTC) #4
esprehn
6 years, 3 months ago (2014-09-19 02:56:53 UTC) #5
On 2014/09/19 02:28:27, tasak wrote:
> On 2014/09/19 01:32:36, esprehn wrote:
> 
> I think, this patch should consider -webkit prefixed custom pseudo, e.g.
> 
> <style>
> input::-webkit-slider-thumb { ... }
> </style>

I see, we do need to traverse up the tree, but only for elements with
shadowPseudoId().

Powered by Google App Engine
This is Rietveld 408576698