Issue 844963002: Refactor StyleResolver::matchAuthorRules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 844963002: Refactor StyleResolver::matchAuthorRules. (Closed)

Created:
5 years, 11 months ago by rune

Modified:
5 years, 11 months ago

Reviewers:
esprehn, hayato

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, sof

Base URL:
https://chromium.googlesource.com/chromium/blink.git@style-scoped-20150109

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Refactor StyleResolver::matchAuthorRules. Simplify the code after https://codereview.chromium.org/843773002 BUG=401359 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188361

Patch Set 1 #

Patch Set 2 : Corrected comment to include ::content #

Patch Set 3 : Rebased #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -28 lines)			Patch
M	Source/core/css/resolver/StyleResolver.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1 2	1 chunk	+10 lines, -26 lines	0 comments	Download
M	Source/core/dom/StyleEngine.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844963002/40001

5 years, 11 months ago (2015-01-14 06:52:07 UTC) #6

commit-bot: I haz the power

5 years, 11 months ago (2015-01-14 08:07:29 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188361

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages