Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 842303002: Remove Telemetry's Chrome tracing dependency on having a BrowserBackend. (Closed)

Created:
5 years, 11 months ago by chrishenry
Modified:
5 years, 11 months ago
Reviewers:
nednguyen, tonyg, nduca, sullivan
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Telemetry's Chrome tracing dependency on BrowserBackend. TracingController now directly communicates with DevToolsClientBackend instead. This allows us to use TracingController on Android app as well. BUG=443897 Committed: https://crrev.com/f0942032455ca36a68d020b5c86bc70304cb0357 Cr-Commit-Position: refs/heads/master@{#311315}

Patch Set 1 : Initial version. #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix for android_process. #

Total comments: 3

Patch Set 4 : Add doc. #

Total comments: 1

Messages

Total messages: 14 (5 generated)
chrishenry
5 years, 11 months ago (2015-01-10 00:36:31 UTC) #4
nednguyen
https://codereview.chromium.org/842303002/diff/80001/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py File tools/telemetry/telemetry/core/platform/tracing_controller_backend.py (right): https://codereview.chromium.org/842303002/diff/80001/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py#newcode53 tools/telemetry/telemetry/core/platform/tracing_controller_backend.py:53: if self._current_trace_options.enable_chrome_trace: Don't we need to remove stale devtool ...
5 years, 11 months ago (2015-01-12 17:21:27 UTC) #5
nednguyen
@Nat: This chrome tracing situation is quite messy. This is the best Chris & me ...
5 years, 11 months ago (2015-01-12 17:37:53 UTC) #7
chrishenry
https://codereview.chromium.org/842303002/diff/80001/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py File tools/telemetry/telemetry/core/platform/tracing_controller_backend.py (right): https://codereview.chromium.org/842303002/diff/80001/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py#newcode53 tools/telemetry/telemetry/core/platform/tracing_controller_backend.py:53: if self._current_trace_options.enable_chrome_trace: On 2015/01/12 17:21:27, nednguyen wrote: > Don't ...
5 years, 11 months ago (2015-01-12 23:45:37 UTC) #8
nednguyen
https://codereview.chromium.org/842303002/diff/80001/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py File tools/telemetry/telemetry/core/platform/tracing_controller_backend.py (right): https://codereview.chromium.org/842303002/diff/80001/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py#newcode53 tools/telemetry/telemetry/core/platform/tracing_controller_backend.py:53: if self._current_trace_options.enable_chrome_trace: On 2015/01/12 23:45:37, chrishenry wrote: > On ...
5 years, 11 months ago (2015-01-13 16:12:00 UTC) #9
nednguyen
lgtm
5 years, 11 months ago (2015-01-13 18:21:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842303002/100001
5 years, 11 months ago (2015-01-13 18:23:13 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 11 months ago (2015-01-13 20:01:14 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 20:02:44 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f0942032455ca36a68d020b5c86bc70304cb0357
Cr-Commit-Position: refs/heads/master@{#311315}

Powered by Google App Engine
This is Rietveld 408576698