tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py - Issue 842303002: Remove Telemetry's Chrome tracing dependency on having a BrowserBackend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Issue 842303002: Remove Telemetry's Chrome tracing dependency on having a BrowserBackend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add doc. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/android_process.py ('k') | tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py » ('j') | tools/telemetry/telemetry/core/platform/tracing_controller_backend.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

index 4dba844dfec9bd0645be30b6f4e2e77f094b72d9..0551ea9d5004cd6fa521515e8d02969f11ee7a9e 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

@@ -259,11 +259,12 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

action=None, data=url, category=None),

blocking=True)

- self.platform_backend.ForwardHostToDevice(

- self._port, self._backend_settings.GetDevtoolsRemotePort(self._adb))

+ remote_devtools_port = self._backend_settings.GetDevtoolsRemotePort(

+ self._adb)

+ self.platform_backend.ForwardHostToDevice(self._port, remote_devtools_port)

try:

- self._WaitForBrowserToComeUp()

+ self._WaitForBrowserToComeUp(remote_devtools_port=remote_devtools_port)

except exceptions.BrowserGoneException:

logging.critical('Failed to connect to browser.')

if not self._adb.device().old_interface.CanAccessProtectedFileContents():