tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py - Issue 842303002: Remove Telemetry's Chrome tracing dependency on having a BrowserBackend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py

Issue 842303002: Remove Telemetry's Chrome tracing dependency on having a BrowserBackend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add doc. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py ('k') | tools/telemetry/telemetry/core/platform/tracing_controller_backend.py » ('j') | tools/telemetry/telemetry/core/platform/tracing_controller_backend.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py

index 1d73d9e687742a37632ea5feca6fdb5c3d8baf55..1a4d10c5eb1798bc9d3a8ceb503588babd0a37b3 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py

@@ -24,13 +24,6 @@ class DevToolsClientBackendTest(browser_test_case.BrowserTestCase):

def testIsAlive(self):

self.assertTrue(self._devtools_client.IsAlive())

- def testIsNotAlive(self):

- client = devtools_client_backend.DevToolsClientBackend(1000, None)

- def StubRequest(*_, **__):

- raise devtools_http.DevToolsClientConnectionError

- client._devtools_http.Request = StubRequest

- self.assertFalse(client.IsAlive())

def testGetUpdatedInspectableContexts(self):

self._browser.tabs.New()

c1 = self._devtools_client.GetUpdatedInspectableContexts()