Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 841453006: Fix WeakPtrFactory members in Android media classes (Closed)

Created:
5 years, 11 months ago by dmichael (off chromium)
Modified:
5 years, 11 months ago
Reviewers:
teravest
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory members in Android media classes This forces WeakPtrs to be invalidated before other members' destructors run. See the bug or the documentation of WeakPtrFactory for more information. I'm in the process of trying to turn on a clang check for this (see the bug). BUG=303818 TBR=qinmin@chromium.org Committed: https://crrev.com/2dd23c37a08ad705c9cb48ededb18cce29609aa5 Cr-Commit-Position: refs/heads/master@{#311506}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/renderer/media/android/media_source_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/android/media_source_player.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
dmichael (off chromium)
5 years, 11 months ago (2015-01-14 16:12:14 UTC) #1
dmichael (off chromium)
5 years, 11 months ago (2015-01-14 16:57:32 UTC) #3
teravest
lgtm
5 years, 11 months ago (2015-01-14 16:59:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841453006/20001
5 years, 11 months ago (2015-01-14 17:05:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/49041)
5 years, 11 months ago (2015-01-14 17:11:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841453006/20001
5 years, 11 months ago (2015-01-14 17:16:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 17:59:59 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 18:01:41 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2dd23c37a08ad705c9cb48ededb18cce29609aa5
Cr-Commit-Position: refs/heads/master@{#311506}

Powered by Google App Engine
This is Rietveld 408576698