Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: content/renderer/media/android/media_source_delegate.h

Issue 841453006: Fix WeakPtrFactory members in Android media classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/android/media_source_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/android/media_source_delegate.h
diff --git a/content/renderer/media/android/media_source_delegate.h b/content/renderer/media/android/media_source_delegate.h
index 963237a93d0c5d1f2349b2dfd49baf771b386b02..5e55066bd0177bf705383c874221fb05dc43abb6 100644
--- a/content/renderer/media/android/media_source_delegate.h
+++ b/content/renderer/media/android/media_source_delegate.h
@@ -227,9 +227,9 @@ class MediaSourceDelegate : public media::DemuxerHost {
const scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_;
// NOTE: Weak pointers must be invalidated before all other member variables.
+ base::WeakPtr<MediaSourceDelegate> main_weak_this_;
base::WeakPtrFactory<MediaSourceDelegate> main_weak_factory_;
base::WeakPtrFactory<MediaSourceDelegate> media_weak_factory_;
- base::WeakPtr<MediaSourceDelegate> main_weak_this_;
DISALLOW_COPY_AND_ASSIGN(MediaSourceDelegate);
};
« no previous file with comments | « no previous file | content/renderer/media/android/media_source_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698