content/renderer/media/android/media_source_delegate.cc - Issue 841453006: Fix WeakPtrFactory members in Android media classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/media_source_delegate.cc

Issue 841453006: Fix WeakPtrFactory members in Android media classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/android/media_source_delegate.cc

diff --git a/content/renderer/media/android/media_source_delegate.cc b/content/renderer/media/android/media_source_delegate.cc

index 484c50090f9fc3c11677c5a7fde17c558e68e1ff..cac700332fe8a52fee2967d6a1e70fc987176618 100644

--- a/content/renderer/media/android/media_source_delegate.cc

+++ b/content/renderer/media/android/media_source_delegate.cc

@@ -65,8 +65,8 @@ MediaSourceDelegate::MediaSourceDelegate(

main_task_runner_(base::MessageLoopProxy::current()),

media_task_runner_(media_task_runner),

main_weak_factory_(this),

- media_weak_factory_(this),

- main_weak_this_(main_weak_factory_.GetWeakPtr()) {

+ media_weak_factory_(this) {

+ main_weak_this_ = main_weak_factory_.GetWeakPtr();

DCHECK(main_task_runner_->BelongsToCurrentThread());

}