Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: content/renderer/media/android/media_source_delegate.h

Issue 841453006: Fix WeakPtrFactory members in Android media classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/media/android/media_source_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_MEDIA_SOURCE_DELEGATE_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_MEDIA_SOURCE_DELEGATE_H_
6 #define CONTENT_RENDERER_MEDIA_ANDROID_MEDIA_SOURCE_DELEGATE_H_ 6 #define CONTENT_RENDERER_MEDIA_ANDROID_MEDIA_SOURCE_DELEGATE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 base::TimeDelta browser_seek_time_; 220 base::TimeDelta browser_seek_time_;
221 bool expecting_regular_seek_; 221 bool expecting_regular_seek_;
222 222
223 size_t access_unit_size_; 223 size_t access_unit_size_;
224 224
225 // Task runner for main renderer and media threads. 225 // Task runner for main renderer and media threads.
226 const scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_; 226 const scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_;
227 const scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_; 227 const scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_;
228 228
229 // NOTE: Weak pointers must be invalidated before all other member variables. 229 // NOTE: Weak pointers must be invalidated before all other member variables.
230 base::WeakPtr<MediaSourceDelegate> main_weak_this_;
230 base::WeakPtrFactory<MediaSourceDelegate> main_weak_factory_; 231 base::WeakPtrFactory<MediaSourceDelegate> main_weak_factory_;
231 base::WeakPtrFactory<MediaSourceDelegate> media_weak_factory_; 232 base::WeakPtrFactory<MediaSourceDelegate> media_weak_factory_;
232 base::WeakPtr<MediaSourceDelegate> main_weak_this_;
233 233
234 DISALLOW_COPY_AND_ASSIGN(MediaSourceDelegate); 234 DISALLOW_COPY_AND_ASSIGN(MediaSourceDelegate);
235 }; 235 };
236 236
237 } // namespace content 237 } // namespace content
238 238
239 #endif // CONTENT_RENDERER_MEDIA_ANDROID_MEDIA_SOURCE_DELEGATE_H_ 239 #endif // CONTENT_RENDERER_MEDIA_ANDROID_MEDIA_SOURCE_DELEGATE_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/media/android/media_source_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698