Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 840403003: First pass at deleting paint invalidation code. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

First pass at deleting paint invalidation code. This is all wasted effort in sky since we invalidate the whole viewport on every frame. We'll probably eventually add back in some invalidation, but it likely won't be rect-based. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/647eb93b6f4ad9d0e0340de8b1acb0c3f0289799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -425 lines) Patch
M sky/engine/core/dom/DocumentMarkerController.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DocumentMarkerController.cpp View 7 chunks +0 lines, -52 lines 0 comments Download
M sky/engine/core/editing/Editor.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/editing/SpellChecker.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 3 chunks +0 lines, -98 lines 0 comments Download
M sky/engine/core/rendering/RenderFlexibleBox.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerModelObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerModelObject.cpp View 2 chunks +0 lines, -20 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerRepainter.h View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerRepainter.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 9 chunks +3 lines, -49 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 6 chunks +2 lines, -136 lines 0 comments Download
M sky/engine/core/rendering/RenderObjectChildList.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderSelectionInfo.h View 4 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
5 years, 11 months ago (2015-01-09 23:09:08 UTC) #2
ojan
5 years, 11 months ago (2015-01-09 23:20:40 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
647eb93b6f4ad9d0e0340de8b1acb0c3f0289799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698