Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: sky/engine/core/rendering/RenderView.cpp

Issue 840403003: First pass at deleting paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderSelectionInfo.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 void RenderView::invalidateTreeIfNeeded(const PaintInvalidationState& paintInval idationState) 278 void RenderView::invalidateTreeIfNeeded(const PaintInvalidationState& paintInval idationState)
279 { 279 {
280 ASSERT(!needsLayout()); 280 ASSERT(!needsLayout());
281 281
282 // We specifically need to issue paint invalidations for the viewRect since other renderers 282 // We specifically need to issue paint invalidations for the viewRect since other renderers
283 // short-circuit on full-paint invalidation. 283 // short-circuit on full-paint invalidation.
284 LayoutRect dirtyRect = viewRect(); 284 LayoutRect dirtyRect = viewRect();
285 if (doingFullPaintInvalidation() && !dirtyRect.isEmpty()) { 285 if (doingFullPaintInvalidation() && !dirtyRect.isEmpty()) {
286 const RenderLayerModelObject* paintInvalidationContainer = &paintInvalid ationState.paintInvalidationContainer(); 286 const RenderLayerModelObject* paintInvalidationContainer = &paintInvalid ationState.paintInvalidationContainer();
287 mapRectToPaintInvalidationBacking(paintInvalidationContainer, dirtyRect, &paintInvalidationState); 287 mapRectToPaintInvalidationBacking(paintInvalidationContainer, dirtyRect, &paintInvalidationState);
288 invalidatePaintUsingContainer(paintInvalidationContainer, dirtyRect, Inv alidationFull);
289 } 288 }
290 RenderBlock::invalidateTreeIfNeeded(paintInvalidationState); 289 RenderBlock::invalidateTreeIfNeeded(paintInvalidationState);
291 } 290 }
292 291
293 void RenderView::invalidatePaintForRectangle(const LayoutRect& paintInvalidation Rect) const 292 void RenderView::invalidatePaintForRectangle(const LayoutRect& paintInvalidation Rect) const
294 { 293 {
295 ASSERT(!paintInvalidationRect.isEmpty()); 294 ASSERT(!paintInvalidationRect.isEmpty());
296 295
297 if (m_frameView) 296 if (m_frameView)
298 m_frameView->contentRectangleForPaintInvalidation(pixelSnappedIntRect(pa intInvalidationRect)); 297 m_frameView->contentRectangleForPaintInvalidation(pixelSnappedIntRect(pa intInvalidationRect));
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
703 m_iframes.remove(iframe); 702 m_iframes.remove(iframe);
704 } 703 }
705 704
706 void RenderView::updateIFramesAfterLayout() 705 void RenderView::updateIFramesAfterLayout()
707 { 706 {
708 for (auto& iframe: m_iframes) 707 for (auto& iframe: m_iframes)
709 iframe->updateWidgetBounds(); 708 iframe->updateWidgetBounds();
710 } 709 }
711 710
712 } // namespace blink 711 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderSelectionInfo.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698