sky/engine/core/rendering/RenderFlexibleBox.cpp - Issue 840403003: First pass at deleting paint invalidation code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderFlexibleBox.cpp

Issue 840403003: First pass at deleting paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderFlexibleBox.cpp

diff --git a/sky/engine/core/rendering/RenderFlexibleBox.cpp b/sky/engine/core/rendering/RenderFlexibleBox.cpp

index 349314e53e9c1dfbec3fa01f01f339091228d59a..e81aaa5924d4efbd57e6d5f897c3a138fd539996 100644

--- a/sky/engine/core/rendering/RenderFlexibleBox.cpp

+++ b/sky/engine/core/rendering/RenderFlexibleBox.cpp

@@ -990,9 +990,6 @@ void RenderFlexibleBox::layoutAndPlaceChildren(LayoutUnit& crossAxisOffset, cons

continue;

}

- // FIXME Investigate if this can be removed based on other flags. crbug.com/370010

- child->setMayNeedPaintInvalidation(true);

LayoutUnit childPreferredSize = childSizes[i] + mainAxisBorderAndPaddingExtentForChild(child);

setLogicalOverrideSize(child, childPreferredSize);

if (childPreferredSize != mainAxisExtentForChild(child)) {

« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/engine/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »