[CSS Shapes] Properly shrink boxes to avoid shape-outside

[CSS Shapes] Properly shrink boxes to avoid shape-outside

To determine how much an box needs to shink to avoid a float, the code
was only taking into account the first line of the box. This doesn't
work when the float has a shape, as it can make it seem like there is
more space on the line than there actually is. This patch changes the
calculations to take into account the entire height of the box that
needs to be shrunk, and thus computes the correct amount of space
available.

This is a merge of http://trac.webkit.org/changeset/178045 and
http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>;.

BUG=427989
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188850

[rwlbuis, 2015-01-08 16:58:41]

rob.buis@samsung.com changed reviewers:
+ bjonesbe@adobe.com

[rwlbuis, 2015-01-08 16:58:41]

PTAL. This seems almost ready, but two things still left I think:

1. could you import the WebKit bug? My importer tool seems broken :(
2. could we come up with a shorter Subject?

[rwlbuis, 2015-01-08 21:10:21]

On 2015/01/08 16:58:41, rwlbuis wrote:
> PTAL. This seems almost ready, but two things still left I think:
> 
> 1. could you import the WebKit bug? My importer tool seems broken :(
> 2. could we come up with a shorter Subject?

Nm the first issue, I found the bug :) Remains only review
and maybe issue 2.

[Bem Jones-Bey (adobe), 2015-01-08 23:57:40]

On 2015/01/08 21:10:21, rwlbuis wrote:
> On 2015/01/08 16:58:41, rwlbuis wrote:
> > PTAL. This seems almost ready, but two things still left I think:
> > 
> > 1. could you import the WebKit bug? My importer tool seems broken :(
> > 2. could we come up with a shorter Subject?
> 
> Nm the first issue, I found the bug :) Remains only review
> and maybe issue 2.

For issue 2, maybe you could name it "Properly shrink boxes to avoid
shape-outside".

The patch itself lgtm.

[rwlbuis, 2015-01-09 00:46:38]

On 2015/01/08 23:57:40, Bem Jones-Bey (adobe) wrote:
> On 2015/01/08 21:10:21, rwlbuis wrote:
> > On 2015/01/08 16:58:41, rwlbuis wrote:
> > > PTAL. This seems almost ready, but two things still left I think:
> > > 
> > > 1. could you import the WebKit bug? My importer tool seems broken :(
> > > 2. could we come up with a shorter Subject?
> > 
> > Nm the first issue, I found the bug :) Remains only review
> > and maybe issue 2.
> 
> For issue 2, maybe you could name it "Properly shrink boxes to avoid
> shape-outside".

Done, will hand off to levi now.

[rwlbuis, 2015-01-09 00:47:02]

rob.buis@samsung.com changed reviewers:
+ leviw@chromium.org

[rwlbuis, 2015-01-09 00:47:03]

@leviw PTAL

[rwlbuis, 2015-01-22 19:48:45]

On 2015/01/09 00:47:03, rwlbuis wrote:
> @leviw PTAL

ping again! :)

[leviw_travelin_and_unemployed, 2015-01-22 19:58:21]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-01-22 19:58:22]

Makes sense. LGTM.

[commit-bot: I haz the power, 2015-01-22 19:59:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/839843004/40001

[commit-bot: I haz the power, 2015-01-22 23:39:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 23:39:28]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[rwlbuis, 2015-01-22 23:58:04]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-01-22 23:59:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/839843004/40001

[commit-bot: I haz the power, 2015-01-23 03:53:46]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188850

[leviw_travelin_and_unemployed, 2015-04-02 19:36:30]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1054063004/ by leviw@chromium.org.

The reason for reverting is: Caused layout issues on ibm.com. crbug.com/463040.