Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1054063004: Revert of [CSS Shapes] Properly shrink boxes to avoid shape-outside (Closed)

Created:
5 years, 8 months ago by leviw_travelin_and_unemployed
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of [CSS Shapes] Properly shrink boxes to avoid shape-outside (patchset #3 id:40001 of https://codereview.chromium.org/839843004/) Reason for revert: Caused layout issues on ibm.com. crbug.com/463040 Original issue's description: > [CSS Shapes] Properly shrink boxes to avoid shape-outside > > To determine how much an box needs to shink to avoid a float, the code > was only taking into account the first line of the box. This doesn't > work when the float has a shape, as it can make it seem like there is > more space on the line than there actually is. This patch changes the > calculations to take into account the entire height of the box that > needs to be shrunk, and thus computes the correct amount of space > available. > > This is a merge of http://trac.webkit.org/changeset/178045 and > http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>;. > > BUG=427989 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188850 TBR=bjonesbe@adobe.com,rob.buis@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=427989 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193051

Patch Set 1 #

Patch Set 2 : Fix revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -245 lines) Patch
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden.html View 1 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden-expected.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden-left-margin.html View 1 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden-left-margin-expected.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden-left-margin-vertical.html View 1 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden-left-margin-vertical-expected.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden-right-margin.html View 1 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden-right-margin-expected.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden-right-margin-vertical.html View 1 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden-right-margin-vertical-expected.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden-vertical.html View 1 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/shapes/shape-outside-floats/shape-overflow-hidden-vertical-expected.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
leviw_travelin_and_unemployed
Created Revert of [CSS Shapes] Properly shrink boxes to avoid shape-outside
5 years, 8 months ago (2015-04-02 19:36:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054063004/1
5 years, 8 months ago (2015-04-02 19:37:28 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/RenderBox.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
5 years, 8 months ago (2015-04-02 19:38:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054063004/250001
5 years, 8 months ago (2015-04-02 19:58:15 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 19:59:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:250001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193051

Powered by Google App Engine
This is Rietveld 408576698