Failed to apply patch for Source/core/rendering/RenderBox.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
5 years, 8 months ago
(2015-04-02 19:38:31 UTC)
#4
Failed to apply patch for Source/core/rendering/RenderBox.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
can't find file to patch at input line 6
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: Source/core/rendering/RenderBox.cpp
|diff --git a/Source/core/rendering/RenderBox.cpp
b/Source/core/rendering/RenderBox.cpp
|index
9aaddd7f22fb7ecad4ff8baedaaca3eb57fe255d..b4c3939d511b886855b77a039883d27d13d96512
100644
|--- a/Source/core/rendering/RenderBox.cpp
|+++ b/Source/core/rendering/RenderBox.cpp
--------------------------
No file to patch. Skipping patch.
1 out of 1 hunk ignored
Patch: Source/core/rendering/RenderBox.cpp
Index: Source/core/rendering/RenderBox.cpp
diff --git a/Source/core/rendering/RenderBox.cpp
b/Source/core/rendering/RenderBox.cpp
index
9aaddd7f22fb7ecad4ff8baedaaca3eb57fe255d..b4c3939d511b886855b77a039883d27d13d96512
100644
--- a/Source/core/rendering/RenderBox.cpp
+++ b/Source/core/rendering/RenderBox.cpp
@@ -1458,15 +1458,14 @@
LayoutUnit logicalTopPosition = logicalTop();
LayoutUnit startOffsetForContent = cb->startOffsetForContent();
LayoutUnit endOffsetForContent = cb->endOffsetForContent();
- LayoutUnit logicalHeight = cb->logicalHeightForChild(*this);
- LayoutUnit startOffsetForLine = cb->startOffsetForLine(logicalTopPosition,
false, logicalHeight);
- LayoutUnit endOffsetForLine = cb->endOffsetForLine(logicalTopPosition,
false, logicalHeight);
+ LayoutUnit startOffsetForLine = cb->startOffsetForLine(logicalTopPosition,
false);
+ LayoutUnit endOffsetForLine = cb->endOffsetForLine(logicalTopPosition,
false);
// If there aren't any floats constraining us then allow the margins to
shrink/expand the width as much as they want.
if (startOffsetForContent == startOffsetForLine && endOffsetForContent ==
endOffsetForLine)
- return cb->availableLogicalWidthForLine(logicalTopPosition, false,
logicalHeight) - childMarginStart - childMarginEnd;
-
- LayoutUnit width = cb->availableLogicalWidthForLine(logicalTopPosition,
false, logicalHeight) - std::max(LayoutUnit(), childMarginStart) -
std::max(LayoutUnit(), childMarginEnd);
+ return cb->availableLogicalWidthForLine(logicalTopPosition, false) -
childMarginStart - childMarginEnd;
+
+ LayoutUnit width = cb->availableLogicalWidthForLine(logicalTopPosition,
false) - std::max(LayoutUnit(), childMarginStart) - std::max(LayoutUnit(),
childMarginEnd);
// We need to see if margins on either the start side or the end side can
contain the floats in question. If they can,
// then just using the line width is inaccurate. In the case where a float
completely fits, we don't need to use the line
// offset at all, but can instead push all the way to the content edge of
the containing block. In the case where the float
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
5 years, 8 months ago
(2015-04-02 19:57:17 UTC)
#5
Issue 1054063004: Revert of [CSS Shapes] Properly shrink boxes to avoid shape-outside
(Closed)
Created 5 years, 8 months ago by leviw_travelin_and_unemployed
Modified 5 years, 8 months ago
Reviewers: Bem Jones-Bey (adobe), rwlbuis
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 0