Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 834653003: [Slimming paint] [New Multicolumn] Repaint column rules when they change. (Closed)

Created:
5 years, 11 months ago by mstensho (USE GERRIT)
Modified:
5 years, 11 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, chromiumbugtracker_adobe.com, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Slimming paint] [New Multicolumn] Repaint column rules when they change. And DON'T paint them when they don't change, or we'll get an assertion failure. Column rules are painted by an anonymous RenderMultiColumnSet, while -webkit-column-rule is specified on the parent multicol, so some extra work is required to properly invalidate the column set(s). BUG=449118 R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188489

Patch Set 1 #

Total comments: 3

Patch Set 2 : Make the test useful. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
A LayoutTests/fast/multicol/change-column-rule.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/change-column-rule-expected.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/paint/MultiColumnSetPainter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
Please take a look. It seems that I need some help with writing a useful ...
5 years, 11 months ago (2015-01-15 13:31:51 UTC) #1
mstensho (USE GERRIT)
https://codereview.chromium.org/834653003/diff/1/LayoutTests/fast/multicol/change-column-rule.html File LayoutTests/fast/multicol/change-column-rule.html (right): https://codereview.chromium.org/834653003/diff/1/LayoutTests/fast/multicol/change-column-rule.html#newcode15 LayoutTests/fast/multicol/change-column-rule.html:15: setTimeout(foo, 1000); On 2015/01/15 13:31:51, mstensho wrote: > This ...
5 years, 11 months ago (2015-01-15 14:09:54 UTC) #2
chrishtr
lgtm
5 years, 11 months ago (2015-01-15 18:54:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834653003/20001
5 years, 11 months ago (2015-01-15 18:55:32 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 20:29:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188489

Powered by Google App Engine
This is Rietveld 408576698