LayoutTests/fast/multicol/change-column-rule.html - Issue 834653003: [Slimming paint] [New Multicolumn] Repaint column rules when they change.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/change-column-rule.html

Issue 834653003: [Slimming paint] [New Multicolumn] Repaint column rules when they change. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>The rules below should be green.</p>

	3 <p>Click to test if testing manually.</p>

	4 <div id="mc" style="-webkit-columns:3; line-height:100px; -webkit-column-rule:so lid yellow;">

	5 <br>

	6 <br>

	7 <br>

	8 </div>

	9 <script>

	10 if (window.testRunner)

	11 testRunner.waitUntilDone();

	12 onclick = foo;

	13 onload = function() {

	14 if (window.internals)

	15 setTimeout(foo, 1000);
	mstensho (USE GERRIT) 2015/01/15 13:31:51 This test is broken. Even with this silly timeout, This test is broken. Even with this silly timeout, I don't get it painted before changing the style. In other words, this test also passes without the code changes in this CL, so it's currently useless. mstensho (USE GERRIT) 2015/01/15 14:09:54 With some suggestions from Rune, we found a way to Show quoted text On 2015/01/15 13:31:51, mstensho wrote: > This test is broken. Even with this silly timeout, I don't get it painted before > changing the style. In other words, this test also passes without the code > changes in this CL, so it's currently useless. With some suggestions from Rune, we found a way to make this test useful, by calling testRunner.displayAsyncThen(). Done.
	16 }

	17 function foo() {

	18 document.getElementById('mc').style.webkitColumnRuleColor = 'green';

	19 if (window.testRunner)

	20 testRunner.notifyDone();

	21 }

	22 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/change-column-rule-expected.html » ('j') | Source/core/rendering/RenderBlockFlow.cpp » ('J')