Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: Source/core/rendering/RenderMultiColumnFlowThread.h

Issue 834653003: [Slimming paint] [New Multicolumn] Repaint column rules when they change. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make the test useful. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 145
146 virtual LayoutSize columnOffset(const LayoutPoint&) const override final; 146 virtual LayoutSize columnOffset(const LayoutPoint&) const override final;
147 147
148 // Do we need to set a new width and lay out? 148 // Do we need to set a new width and lay out?
149 virtual bool needsNewWidth() const; 149 virtual bool needsNewWidth() const;
150 150
151 void layoutColumns(bool relayoutChildren, SubtreeLayoutScope&); 151 void layoutColumns(bool relayoutChildren, SubtreeLayoutScope&);
152 152
153 bool recalculateColumnHeights(); 153 bool recalculateColumnHeights();
154 154
155 void columnRuleStyleDidChange();
156
155 protected: 157 protected:
156 RenderMultiColumnFlowThread(); 158 RenderMultiColumnFlowThread();
157 void setProgressionIsInline(bool isInline) { m_progressionIsInline = isInlin e; } 159 void setProgressionIsInline(bool isInline) { m_progressionIsInline = isInlin e; }
158 160
159 virtual void layout() override; 161 virtual void layout() override;
160 162
161 private: 163 private:
162 void calculateColumnCountAndWidth(LayoutUnit& width, unsigned& count) const; 164 void calculateColumnCountAndWidth(LayoutUnit& width, unsigned& count) const;
163 void createAndInsertMultiColumnSet(); 165 void createAndInsertMultiColumnSet();
164 void createAndInsertSpannerPlaceholder(RenderBox* spanner); 166 void createAndInsertSpannerPlaceholder(RenderBox* spanner);
(...skipping 16 matching lines...) Expand all
181 LayoutUnit m_columnHeightAvailable; // Total height available to columns, or 0 if auto. 183 LayoutUnit m_columnHeightAvailable; // Total height available to columns, or 0 if auto.
182 bool m_inBalancingPass; // Set when relayouting for column balancing. 184 bool m_inBalancingPass; // Set when relayouting for column balancing.
183 bool m_needsColumnHeightsRecalculation; // Set when we need to recalculate t he column set heights after layout. 185 bool m_needsColumnHeightsRecalculation; // Set when we need to recalculate t he column set heights after layout.
184 bool m_progressionIsInline; // Always true for regular multicol. False for p aged-y overflow. 186 bool m_progressionIsInline; // Always true for regular multicol. False for p aged-y overflow.
185 bool m_isBeingEvacuated; 187 bool m_isBeingEvacuated;
186 }; 188 };
187 189
188 } // namespace blink 190 } // namespace blink
189 191
190 #endif // RenderMultiColumnFlowThread_h 192 #endif // RenderMultiColumnFlowThread_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBlockFlow.cpp ('k') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698